[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#602207: xserver-xorg-video-intel: Swiching SDL window to fullscreen causes black screen



I believe I've found where the problem was introduced, but I don't have
a proper solution.  I'd appreciate it if any of you are able to code up
thing to replace the buggy uxa_put_image code.

The problem was introduced in

  commit 19d8c0cf "uxa: PutImage acceleration"

which can be verified by checking out 2.10.0 and reverting just this
commit.  

It does not revert cleanly in later versions but the attached patch
against 2.12.0 will have the same effect, leaving some dead code around.
Unfortunately, this quickfix will also impact performance.  So if anyone
is able to fix the i830_uxa_put_image() code instead, that would be
preferred... 



Bjørn


>From baf201d496e46dd8ec6f687bcacde02dfa0df4b9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B8rn=20Mork?= <bjorn@mork.no>
Date: Thu, 4 Nov 2010 15:51:55 +0100
Subject: [PATCH] testing whether removing put_image will fix the black screen problem
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Bjørn Mork <bjorn@mork.no>
---
 src/i830_uxa.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/src/i830_uxa.c b/src/i830_uxa.c
index 61e857f..c34ba18 100644
--- a/src/i830_uxa.c
+++ b/src/i830_uxa.c
@@ -1157,7 +1157,6 @@ Bool i830_uxa_init(ScreenPtr screen)
 	}
 
 	/* PutImage */
-	intel->uxa_driver->put_image = i830_uxa_put_image;
 	intel->uxa_driver->get_image = i830_uxa_get_image;
 
 	intel->uxa_driver->prepare_access = i830_uxa_prepare_access;
-- 
1.7.2.3


Reply to: