[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#505976: FTBFS: PACKAGE_VERSION in configure is corrupted by excess make spew



On Mon, Nov 17, 2008 at 06:24:27 -0500, EspeonEefi wrote:

> The invocation of make being used in configure.ac to generate
> mesa_version (which later goes into PACKAGE_VERSION in configure) is
> missing a --no-print-directory switch. The lack of --no-print-directory
> is resulting in the following line in the generated configure:
> 
> PACKAGE_VERSION='make2: Entering directory `/root/mesa-7.2'7.2.0make2: Leaving directory `/root/mesa-7.2''
> 
> Subsequently, all kinds of badness happens when attempts are made to use
> this malformed configure script.
> 
> The following patch I've found fixes this problem:
> 
> diff -Naur mesa-7.2.orig/configure.ac mesa-7.2/configure.ac
> --- mesa-7.2.orig/configure.ac  2008-09-13 20:25:44.000000000 +0000
> +++ mesa-7.2/configure.ac       2008-11-17 08:21:36.445563599 +0000
> @@ -4,7 +4,7 @@
>  
>  dnl Versioning - scrape the version from configs/default
>  m4_define([mesa_version],
> -    [m4_esyscmd([${MAKE-make} -s -f bin/version.mk version | tr -d '\n'])])
> +    [m4_esyscmd([${MAKE-make} -s --no-print-directory -f bin/version.mk version | tr -d '\n'])])
>  m4_ifval(mesa_version,[],[
>      m4_errprint([Error: Failed to get the Mesa version from the output of
>         running `make -f bin/version.mk version'
> 
info make suggests that the -s option turns off --print-directory.
What's the story here? (Obviously we haven't seen mesa ftbfs because of
this so far...)

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: