On Tuesday 18 May 2010 20:05:43 Julien Cristau wrote:
> Hi,
>
> I just had a quick look at the git repo. The packaging looks sane
> enough. The git tree is kind of a mess though. It would be nicer IMO
> to directly pull from the upstream git tags at
> git://anongit.freedesktop.org/git/xorg/driver/xf86-video-qxl, rather
> than dump the contents directly. Same goes for debian/xsfbs/ stuff.
>
> Also the code is moved to a versioned xserver-xorg-video-qxl-0.0.12
> subdir inside your git tree, which is not the way to go IMO.
>
> debian/patches/series mentions fix_qxl_driver_assert.patch, but that
> patch is not in the repo (I assume it's upstream's "qxl: remove asserts
> that make no sense anymore" commit).
>
Hi, Julien,
Thanks for your review. For this package is a xorg driver, I've created a new
git repository at git://git.debian.org/git/pkg-xorg/driver/xserver-xorg-video-
qxl.git, this repository has three branch, upstream-unstable hold local copy
of the upstream qxl, xsfbs-unstable hold local copy of debian xsfbs, and
debian-unstable hold the debian directory in addition to the full source tree
from upstream.
I've upload this package to mentors too,
- URL: http://mentors.debian.net/debian/pool/main/x/xserver-xorg-video-qxl
- Source repository: deb-src http://mentors.debian.net/debian unstable main
contrib non-free
- dget http://mentors.debian.net/debian/pool/main/x/xserver-xorg-video-
qxl/xserver-xorg-video-qxl_0.0.12-1.dsc
For this package have never enter official debian repositories, I think it is
proper to use version number 0.0.12-1. I have not create tag in git
repository, I think I should create a tag when this package is good enough to
enter into debian.
There is a strange file debian/xserver-xorg-video-qxl.debhelper.log in
generated package xserver-xorg-video-qxl_0.0.12-1.debian.tar.gz, shoud I
remove it?
> Some minor stuff that could be updated for recent changes in other
> pkg-xorg drivers:
> - rename the build dir from 'obj-$(DEB_BUILD_GNU_TYPE)' to 'build' or
> similar, there's no reason to have the build machine type in there
> (that's just a cosmetic change)
done
> - update xsfbs.mk to the latest version, build-depend on
> xserver-xorg-dev 2:1.7.6.901, and use ${xviddriver:Depends} instead of
> ${xserver:Depends}. This should allow us to handle ABI changes
> without Conflicts/Breaks in the future, see #573371.
done
> - drop the http://xorg.freedesktop.org and mailman urls from
> debian/control
done
Thanks for your review.
--
Liang Guo
http://bluestone.cublog.cn
Attachment:
signature.asc
Description: This is a digitally signed message part.