Re: [PATCH] mesa: do not strip the same packages twice

[Tormod Volden <lists.tormod@gmail.com>]

On Fri, Apr 23, 2010 at 2:27 AM, Julien Cristau <jcristau@debian.org> wrote:
> Hi Tormod,
>
> On Thu, Apr 22, 2010 at 22:29:41 +0200, Tormod Volden wrote:
>
>> From: Tormod Volden <debian.tormod@gmail.com>
>>
>> ---
>>  debian/rules |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/debian/rules b/debian/rules
>> index 8a22ea8..76bed7d 100755
>> --- a/debian/rules
>> +++ b/debian/rules
>> @@ -233,7 +233,7 @@ binary-arch: install
>>       dh_strip -plibgl1-mesa-swx11 --dbg-package=libgl1-mesa-swx11-dbg
>>       dh_strip -plibgl1-mesa-glx --dbg-package=libgl1-mesa-glx-dbg
>>       dh_strip -plibgl1-mesa-dri --dbg-package=libgl1-mesa-dri-dbg
>> -     dh_strip -s
>> +     dh_strip -s --remaining-packages
>>       dh_compress -s
>>       dh_fixperms -s
>>       dh_makeshlibs -s
>
> Can you explain a bit more in the commit message what this fixes?  Is
> that related to the pkg-create-dbgsym issue you had on ubuntu?
>
> Cheers,
> Julien
>

Hi,
It does not necessarily "fix" anything other than that the stripping
is tried twice for the same package. Which I don't think is intended,
and in the best case is a waste of time and CPU cycles. Yes, I
discovered this when tracking down the pkg-create-dbgsym issue.

Cheers,
Tormod