[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#572268: xserver-xorg-core: Crash, Segmentation fault, VidModeSetGamma+0x67, xf86ChangeGamma+0x4b



Cyril Brulebois <kibi@debian.org> (03/03/2010):
> Heh. Please tell us if you find another (smaller) testcase that
> triggers this bug. :)

That still holds. ;)

> Could it be possible to get a full backtrace?
>   http://wiki.debian.org/HowToGetABacktrace

The code being quite trivial, we might not need this in the end.

Could you please apply the attached patch against the “xorg-server”
source package and see whether that fixes your crash?

Mraw,
KiBi.
From fc1f6dd12ed4a3330d54b67a39946047e31ef0bf Mon Sep 17 00:00:00 2001
From: Cyril Brulebois <kibi@debian.org>
Date: Wed, 3 Mar 2010 01:19:26 +0100
Subject: [PATCH] Make sure not to dereference a null pointer.

Signed-off-by: Cyril Brulebois <kibi@debian.org>
---
 hw/xfree86/common/xf86cmap.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/xfree86/common/xf86cmap.c b/hw/xfree86/common/xf86cmap.c
index f60d96e..c9d57be 100644
--- a/hw/xfree86/common/xf86cmap.c
+++ b/hw/xfree86/common/xf86cmap.c
@@ -1160,7 +1160,7 @@ xf86ChangeGamma(
 ){
     ScrnInfoPtr pScrn = xf86Screens[pScreen->myNum];
 
-    if(pScrn->ChangeGamma)
+    if(pScrn && pScrn->ChangeGamma)
 	return (*pScrn->ChangeGamma)(pScreen->myNum, gamma);
 
     return BadImplementation;
-- 
1.7.0

Attachment: signature.asc
Description: Digital signature


Reply to: