[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#541160: #541160 xterm: heap corruption when changing window size



On Thu, 13 Aug 2009, Jan Christoph Nordholz wrote:

Hi Thomas,

This one is hard to reproduce (here).  valgrind is not showing me any
problems as I resize the screen in various ways.

There are several special cases in the resizing logic, depending on
resource-settings, as well as the amount of text that has been scrolled
off onto the saved-lines buffer.

More details would be helpful...

while Julien has uploaded a new xterm package with fifo-lines disabled,
I can still help debugging the actual problem if this is desired. I
can reliably reproduce the problem with an empty (i.e. freshly started)
xterm with a bare prompt - once the buffer is full I can no longer make
it crash. My .Xresources only contains modifications to the font settings.

I'll do a few valgrind runs myself and report back.

The positioning problem is mostly a logic error (incorrect bounds checking) around the call to saveEditBufLines in screen.c; which I think I understand. Once I have a fix for that, I'm interested to see if applying _that_ fix makes this problem go away.

--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net



Reply to: