On Sun, Aug 16, 2009 at 07:01:58PM +0200, Vincent Lefevre wrote: > On 2009-08-16 10:59:14 -0400, Thomas Dickey wrote: > > On Sat, Aug 15, 2009 at 03:26:45AM +0200, Vincent Lefevre wrote: > > > tags 541236 patch > > > thanks > > > > > > On 2009-08-14 20:53:52 -0400, Thomas Dickey wrote: > > > > Here's a copy of current changes for #246, which includes a fix > > > > for this bug. > > > > > > Thanks, I've tested it and it indeed fixes this bug. > > > > Looking at my email, it's not clear whether you still found a segmentation > > violation after applying the patch for alignment, which would also address > > 541160. > > Your patch fixes bug 541236 only. Bug 541160 is still there. > > > Is that still reproducible? > > > > If so, perhaps a valgrind log would help. That's helpful. I'm puzzled (since I don't have all of the traces, etc). I suspect that it's something related to 32/64-bit differences, but it's not apparent. But in investigation, I realized that the chunk which has the problem is actually obsolete (something that's now done as part of the copyLineData function). So the whole chunk can be removed (along with the part that sets up the data). Please verify if the attached diff solves the problem. > ==32696== Warning: invalid file descriptor -1 in syscall close() > ==32692== Invalid write of size 1 > ==32692== at 0x430560: Reallocate (screen.c:547) > ==32692== by 0x4308B9: ScreenResize (screen.c:2009) > ==32692== by 0x5DD03A9: XtConfigureWidget (in /usr/lib/libXt.so.6.0.0) > ==32692== by 0x508E6FF: XawVendorShellExtResize (in /usr/lib/libXaw7.so.7.0.0) > ==32692== by 0x5DCD107: XtDispatchEventToWidget (in /usr/lib/libXt.so.6.0.0) > ==32692== by 0x5DCD92A: (within /usr/lib/libXt.so.6.0.0) > ==32692== by 0x5DCCB3A: XtDispatchEvent (in /usr/lib/libXt.so.6.0.0) > ==32692== by 0x42AE17: xevents (misc.c:459) > ==32692== by 0x4187AD: VTparse (charproc.c:3437) > ==32692== by 0x418BE1: VTRun (charproc.c:4957) > ==32692== by 0x4243B0: main (main.c:2414) > ==32692== Address 0x108103dd2 is not stack'd, malloc'd or (recently) free'd -- Thomas E. Dickey <dickey@invisible-island.net> http://invisible-island.net ftp://invisible-island.net
Attachment:
screen.c.diff.gz
Description: Binary data
Attachment:
signature.asc
Description: Digital signature