Bug#522141: marked as done (xterm 242 sometimes draws spaces without background color)
Your message dated Mon, 10 Aug 2009 15:51:00 +0000
with message-id <E1MaX9I-0006ac-Id@ries.debian.org>
and subject line Bug#522141: fixed in xterm 244-1
has caused the Debian Bug report #522141,
regarding xterm 242 sometimes draws spaces without background color
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)
--
522141: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=522141
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: xterm 242 sometimes draws spaces without background color
- From: Matt Wozniski <mjw@drexel.edu>
- Date: Wed, 1 Apr 2009 01:52:08 -0400
- Message-id: <20090401052358.28681.57704.reportbug@mastermind>
Package: xterm
Version: 242-1
Severity: normal
A regression seems to have been introduced in xterm 242 in handling
spaces with a background color set: sometimes they will be drawn as
though no background color was specified. A simple test case:
# Open a vim process with a red background in xterm
xterm -e 'vim -u NONE -N +"hi Normal ctermbg=red"'
# Insert a line of 50 spaces
50i<space><esc>
# Start moving the cursor left
hhhhhhhhhh
# Notice that most of the screen is red, but the spaces that you've
# moved over aren't colored and appear black.
Removing some lines from charproc.c, as shown below, stops this regression, but
I'm sure it breaks other things - I couldn't quite figure out what, though...
In any event, I don't think these two blocks are behaving as they ought to.
~Matt
diff --git a/charproc.c b/charproc.c
index 97e1c9d..22148c4 100644
--- a/charproc.c
+++ b/charproc.c
@@ -6904,8 +6904,6 @@ ShowCursor(void)
#if OPT_ISO_COLORS
if (base == ' ') {
if ((flags & (FG_COLOR | BG_COLOR)) == BG_COLOR) {
- TRACE(("ShowCursor - do not treat as a colored cell\n"));
- flags &= ~(FG_COLOR | BG_COLOR);
} else if ((flags & (FG_COLOR | BG_COLOR)) == FG_COLOR) {
TRACE(("ShowCursor - should we treat as a colored cell?\n"));
if (!(xw->flags & FG_COLOR))
@@ -7141,8 +7139,6 @@ HideCursor(void)
#if OPT_ISO_COLORS
if (base == ' ') {
if ((flags & (FG_COLOR | BG_COLOR)) == BG_COLOR) {
- TRACE(("HideCursor - do not treat as a colored cell\n"));
- flags &= ~(FG_COLOR | BG_COLOR);
} else if ((flags & (FG_COLOR | BG_COLOR)) == FG_COLOR) {
TRACE(("HideCursor - should we treat as a colored cell?\n"));
if (!(xw->flags & FG_COLOR))
-- System Information:
Debian Release: squeeze/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.29-rc7-2009-03-11+1236796607+bisect (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages xterm depends on:
ii libc6 2.9-6 GNU C Library: Shared libraries
ii libfontconfig1 2.6.0-3 generic font configuration library
ii libice6 2:1.0.5-1 X11 Inter-Client Exchange library
ii libncurses5 5.7+20090321-1 shared libraries for terminal hand
ii libx11-6 2:1.2-1 X11 client-side library
ii libxaw7 2:1.0.5-2 X11 Athena Widget library
ii libxft2 2.1.13-3 FreeType-based font drawing librar
ii libxmu6 2:1.0.4-1 X11 miscellaneous utility library
ii libxt6 1:1.0.5-3 X11 toolkit intrinsics library
ii xbitmaps 1.0.1-2 Base X bitmaps
Versions of packages xterm recommends:
ii x11-utils 7.4+1 X11 utilities
ii xutils 1:7.3+18 X Window System utility programs m
Versions of packages xterm suggests:
pn xfonts-cyrillic <none> (no description available)
-- no debconf information
--- End Message ---
--- Begin Message ---
Source: xterm
Source-Version: 244-1
We believe that the bug you reported is fixed in the latest version of
xterm, which is due to be installed in the Debian FTP archive:
xterm_244-1.diff.gz
to pool/main/x/xterm/xterm_244-1.diff.gz
xterm_244-1.dsc
to pool/main/x/xterm/xterm_244-1.dsc
xterm_244-1_i386.deb
to pool/main/x/xterm/xterm_244-1_i386.deb
xterm_244.orig.tar.gz
to pool/main/x/xterm/xterm_244.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 522141@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Julien Cristau <jcristau@debian.org> (supplier of updated xterm package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 10 Aug 2009 16:30:29 +0200
Source: xterm
Binary: xterm
Architecture: source i386
Version: 244-1
Distribution: unstable
Urgency: low
Maintainer: Debian X Strike Force <debian-x@lists.debian.org>
Changed-By: Julien Cristau <jcristau@debian.org>
Description:
xterm - X terminal emulator
Closes: 378700 458432 522141 538594
Changes:
xterm (244-1) unstable; urgency=low
.
* New upstream release
+ remove a limit-check in ptydata.c, allowing Unicode values past 64k to
be displayed using TrueType fonts (closes: #458432)
+ demote recent (xterm 242) change to Debian #252873 fix to experimental,
ifdef'd out as EXP_BOGUS_FG (closes: #522141)
+ work around groff mapping of ASCII quotes using macros (requested by
Reuben Thomas based on Colin Watson advice (closes: #378700)
* Switch debian/rules to xsfbs instead of copying half of (an outdated
version of) it (closes: #538594). Incidentally, this provides
README.source, and allows us to bump Standards-Version to 3.8.2.
* Remove preinst dealing with upgrades from pre-etch versions.
* Remove from postinst some code to fix pre-etch non-released versions.
* Refresh/update patches.
* Bump debian/compat to 5, as compatibility level 4 has been deprecated.
* Remove obsolete debian/README.
Checksums-Sha1:
8484e62d1fcbcf0059f8a4e9ba40b48d1850f6aa 1339 xterm_244-1.dsc
3393a28bfe19d23d5f234ec5bceafefd61c5986c 882642 xterm_244.orig.tar.gz
155d89746199a8cbbfd868370e1c5c1791f88b0d 73013 xterm_244-1.diff.gz
a890ba49613af766155956c418b76874c3212496 495426 xterm_244-1_i386.deb
Checksums-Sha256:
3758d663b5f4add240ac7fdc16ef0265dabadb2f2c68b41df50c7c1b4f230afd 1339 xterm_244-1.dsc
b253870e0cc4d702a77ae63df1ed8933274f79d56060add48e8ee714ceac1e5b 882642 xterm_244.orig.tar.gz
4be08c3ebe4cc7e9a46a72e3053cee14cbbc37f52b73b7898864bfb7b67c2cfc 73013 xterm_244-1.diff.gz
28a1e3c2e9b37cf12c9d1d0057eed30eeed49b80830e1953ce7ed0d4986d726d 495426 xterm_244-1_i386.deb
Files:
084610a5c7f72f5f5d0b35d50ba14696 1339 x11 optional xterm_244-1.dsc
9133a24dde377ad355139f5d6bc9b336 882642 x11 optional xterm_244.orig.tar.gz
d842c65c7b40d17e89d45e09dc9b6b44 73013 x11 optional xterm_244-1.diff.gz
61295959c9eb34352ed54bd57b930bbe 495426 x11 optional xterm_244-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkqAL7oACgkQmEvTgKxfcAxktQCgpAuUS4CPkbLp2YrITM4+7sEf
wX8AnR3xrRKXLppS3ZqlAD5NleVTQtke
=H6v+
-----END PGP SIGNATURE-----
--- End Message ---
Reply to: