Bug#535624: UNS: Re: Bug#535624: Patch update

[Maximiliano Curia <maxy@debian.org>]

Hola Julien Cristau!

El 27/07/2009 a las 14:16 escribiste:
> >    if [ "$(md5sum "$XORGCONFIG")" = "$(cat "$XORGCONFIG_CHECKSUM")" ] || \
> > -     ! [ -e "$XORGCONFIG" ] || [ -n "$RECONFIGURE" ]; then
> > +     ! [ -e "$XORGCONFIG" ] || [ -n "$RECONFIGURE" ] || \
> > +	 { [ -n "$(find "$XORGCONFIG" -maxdepth 0 -size 0 2>/dev/null)" ] && \
> > +		 [ "$2" = 1:7.3+19 ]; }; then

> I don't understand why this is necessary.
> xserver-xorg.preinst does this:

>   if [ "$1" = "install" ]; then
>     if ! [ -e "$XORGCONFIG" ]; then
>       # cheap, fork()-free version of "touch"
>       : > "$XORGCONFIG"
>       md5sum "$XORGCONFIG" > "$XORGCONFIG_CHECKSUM"
>     fi
>   fi

> so even with the buggy preinst the checksum in $XORGCONFIG_CHECKSUM
> should match the empty file.  What am I missing?

You are most probably right and I had probably mess up with the tests I made
before. I wasn't looking for the source of xorg.conf emptyness, so it should
be fine to remove the modification to the second if. I've tested it (lightly)
again and seems to be fine.

-- 
"We must be very careful when we give advice to younger people: sometimes they
follow it!" -- Edsger W. Dijkstra
Saludos /\/\ /\ >< `/