[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#538536: marked as done (xserver-xorg-video-neomagic: FTBFS with new source format 3.0 (quilt): broken patches)



Your message dated Sun, 26 Jul 2009 00:11:51 +0200
with message-id <4A6B8327.2080606@ens-lyon.org>
and subject line Re: Bug#538536: xserver-xorg-video-neomagic: FTBFS with new source format 3.0 (quilt): broken patches
has caused the Debian Bug report #538536,
regarding xserver-xorg-video-neomagic: FTBFS with new source format 3.0 (quilt): broken patches
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
538536: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538536
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: xserver-xorg-video-neomagic
Version: 1:1.2.2-2
Severity: wishlist
Usertags: 3.0-quilt-by-default

To prepare a possible switch to the new source package format "3.0
(quilt)" [1], I converted all source packages and rebuilt the packages
afterwards to see what breaks, and xserver-xorg-video-neomagic does break. To reproduce the
problem you can do this:
$ apt-get source xserver-xorg-video-neomagic
$ mkdir -p xserver-xorg-video-neomagic-1.2.2/debian/source
$ echo "3.0 (quilt)" >xserver-xorg-video-neomagic-1.2.2/debian/source/format
$ dpkg-source -b xserver-xorg-video-neomagic-1.2.2
$ dpkg-source -x xserver-xorg-video-neomagic_1.2.2-2.dsc
$ cd xserver-xorg-video-neomagic-1.2.2 && debuild -us -uc

In this process, if the .diff.gz contains changes to upstream files,
dpkg-source will have created a corresponding patch in
debian/patches/debian-changes-1:1.2.2-2 and will have registered that
patch in a quilt series (debian/patches/series, it is created if needed).
All the patches listed in the "series" file are applied directly during
the extraction (dpkg-source -x). quilt itself is used if available (and
will thus lead to the creation of the .pc directory), otherwise
dpkg-source applies the patches by itself. For more information about the
new source package format see the manual page dpkg-source(1).

In the case of xserver-xorg-video-neomagic, one of the patches is broken. It has probably
been hand edited without updating the numbers at the start of the hunk.
Please refresh all patches (quilt refresh) to make sure that they are
correct (and verify that the above procedure now works).

Cheers,

[1] http://wiki.debian.org/Projects/DebSrc3.0




--- End Message ---
--- Begin Message ---
Version: 1:1.2.3-1


Brice Goglin wrote:
> hertzog@debian.org wrote:
>   
>> Package: xserver-xorg-video-neomagic
>> Version: 1:1.2.2-2
>> Severity: wishlist
>> Usertags: 3.0-quilt-by-default
>>
>> To prepare a possible switch to the new source package format "3.0
>> (quilt)" [1], I converted all source packages and rebuilt the packages
>> afterwards to see what breaks, and xserver-xorg-video-neomagic does break. To reproduce the
>> problem you can do this:
>> $ apt-get source xserver-xorg-video-neomagic
>> $ mkdir -p xserver-xorg-video-neomagic-1.2.2/debian/source
>> $ echo "3.0 (quilt)" >xserver-xorg-video-neomagic-1.2.2/debian/source/format
>> $ dpkg-source -b xserver-xorg-video-neomagic-1.2.2
>> $ dpkg-source -x xserver-xorg-video-neomagic_1.2.2-2.dsc
>> $ cd xserver-xorg-video-neomagic-1.2.2 && debuild -us -uc
>>
>> In this process, if the .diff.gz contains changes to upstream files,
>> dpkg-source will have created a corresponding patch in
>> debian/patches/debian-changes-1:1.2.2-2 and will have registered that
>> patch in a quilt series (debian/patches/series, it is created if needed).
>> All the patches listed in the "series" file are applied directly during
>> the extraction (dpkg-source -x). quilt itself is used if available (and
>> will thus lead to the creation of the .pc directory), otherwise
>> dpkg-source applies the patches by itself. For more information about the
>> new source package format see the manual page dpkg-source(1).
>>
>> In the case of xserver-xorg-video-neomagic, one of the patches is broken. It has probably
>> been hand edited without updating the numbers at the start of the hunk.
>> Please refresh all patches (quilt refresh) to make sure that they are
>> correct (and verify that the above procedure now works).
>>   
>>     
>
> Most X drivers don't have any patch anymore since we let the upstream
> server do the driver autodetection now. neomagic has not been uploaded
> since the patch was removed in git since no new release occured.

Actually, there's a new 1.2.3 release with nothing interesting, but I
uploaded it anyway.
The above procedure indeed works fine now. Closing.

Brice



--- End Message ---

Reply to: