[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#501373: marked as done ([xserver-xorg] Please do not ask for keyboard layout at high priority for ca fr (French Canadian))

Your message dated Thu, 16 Apr 2009 19:57:39 +0200
with message-id <20090416175739.GA10705@loulous.org>
and subject line Re: Bug#501373: [xserver-xorg] Please do not ask for keyboard layout at high priority for ca fr (French Canadian)
has caused the Debian Bug report #501373,
regarding [xserver-xorg] Please do not ask for keyboard layout at high priority for ca fr (French Canadian)
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
501373: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=501373
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: xserver-xorg
Version: 1:7.3+17
Severity: wishlist
Tags: patch

In xserver-xorg.postinst, when the presetting of keyboard layout from 
console-setup is impossible, like in d-i, xserver-xorg falls back to 
debian-installer/keymap. For example:
    cf) XMAP="ca"; VARIANT="fr";;
means that for the French Canadian console keymap, XKBLAYOUT is set to ca. 
There is a similar mapping for other layouts too, but something is special 
about ca fr:

  if [ "$XMAP" = "UNKNOWN" ]; then
    warn "failed to infer keyboard layout from 
layout/lang '$DI_KEYMAP--$REALLANG'"
    PRIORITY=medium
    XMAP="us"
    MODEL="pc104"
  # prompt for layout if we ended up with French Canadian; apparently having
  # US-layout keyboards is common there
  elif [ "$XMAP" = "ca" ] && [ "$VARIANT" = "fr" ]; then
    PRIORITY=high
  else
    PRIORITY=low
  fi

Setting the debconf prompt to high priority means that people using a French 
Canadian keyboard are prompted twice for the keyboard layout, once for the 
console and once for X, even during a non-expert install. This doesn't make 
sense. It is true that French Canadians often use US English keyboards, but 
of course those that use French Canadian keyboards in console will want the 
same layout in X.

The patch is pretty trivial:

-  # prompt for layout if we ended up with French Canadian; apparently having
-  # US-layout keyboards is common there
-  elif [ "$XMAP" = "ca" ] && [ "$VARIANT" = "fr" ]; then
-    PRIORITY=high

--- End Message ---
--- Begin Message --- 
Keyboard layout is managed by console-setup and hal nowadays,
this old bug doesn't matter anymore.

Brice

--- End Message ---
Reply to: