Bug#523630: xserver-xorg: decription says it is removeable, which is wrong
Package: xserver-xorg
Version: 1:7.3+18
The description of the xserver-xorg package says:
"It does not provide the actual server itself, but removing it is
strongly discouraged."
But since xserver-xorg-core 2:1.1.1-10 that depends on xserver-xorg, so
removing it removes the whole server.
Another solution would be to make the description true again, by
removing the dependency in xserver-xorg-core and moving the /etc/X11/X
symlink handling code to xserver-xorg-core. (according to the changelog,
that was the reason why xserver-xorg-core started to depend on this.
And the symlink handling code seems to only be creating it if it does
not yet exists and nothing else, so moving that should be trivial).
Only downsize in this could be that this might cause something to think
xserver-xorg can be autoremoved, against which a Recommend: in
xserver-xorg-core for a release or two should help.
Hochachtungsvoll,
Bernhard R. Link
P.S: if only changing the description, the xserver-xorg.postinst could
also need some documentation updates:
| # register this package as a (potential) handler of the X server symlink and
| # X.Org X server configuration file
| for ROSTER in "$SERVER_SYMLINK_ROSTER" "$XORGCONFIG_ROSTER"; do
| if ! fgrep -qsx "$THIS_PACKAGE" "$ROSTER"; then
| echo "$THIS_PACKAGE" >> "$ROSTER"
| fi
| done
I think here SERVER_SYMLINK_ROSTER can just be removed. It is no longer used,
and the file is even deleted on upgrading from older versions (so another
package using that file can also be no reason to keep it).
| # only mess with the server symlink file if it is a symbolic link or does
| # not exist. otherwise, assume that's the way the user wants it.
| if ! [ -e "$SERVER_SYMLINK" ]; then
| ln -s "$THIS_SERVER" "$SERVER_SYMLINK"
| # recover from an old bug
| elif [ `readlink "$SERVER_SYMLINK"` = "/bin/true" ]; then
| rm -f "$SERVER_SYMLINK"
| ln -s "$THIS_SERVER" "$SERVER_SYMLINK"
| fi
The commend says "only mess with the server symlink file if it is a symbolic link or does
not exist." but actually, it is only about "if it does not exist"...
| if [ -n "$UPGRADE" ] && dpkg --compare-versions "$2" le "1:7.3+5"; then
| # Clean up our old crap
| rm -f "$SERVER_SYMLINK_CHECKSUM" "$SERVER_SYMLINK_ROSTER"
Reply to: