[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#513399: drm-snapshot: divert old kernel modules every time



Package: drm-snapshot
Severity: normal
Tags: patch

Hi,

if I bootstrap a debian system and install the drm-module without a
kernel, I run in trouble because preinst didn't generate diverts.
Thereafter I install the kernel my X-Server use the old drm modules
shipped by linux-image.
With my attached patch, preinst and postrm didn't check for old modules
and generate diverts ever. So later installed kernel modules will be
renamed by dpkg.

Greetings,
Christoph
From abd17afc92eeb8d2b3d351c3b361844f8d3125d9 Mon Sep 17 00:00:00 2001
From: Christoph Goehre <christoph.goehre@gmx.de>
Date: Wed, 28 Jan 2009 13:02:01 +0100
Subject: [PATCH] divert kernel modules every time

We run in troube if the kernel isn't extract and preinst/postrm of the
drm-module starts.

Bugzilla: #3678
---
 debian/postrm.modules.in  |    8 +++-----
 debian/preinst.modules.in |    8 +++-----
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/debian/postrm.modules.in b/debian/postrm.modules.in
index fc74698..5499d08 100644
--- a/debian/postrm.modules.in
+++ b/debian/postrm.modules.in
@@ -8,11 +8,9 @@ dir=/lib/modules/@KERNEL@/kernel/drivers/char/drm
 case "${1}" in
 	remove)
 		for driver in $drivers; do
-			if [ -e "$dir/$driver.ko.linux" ]; then
-				dpkg-divert --package drm-modules-@KERNEL@ --remove --rename \
-					--divert $dir/$driver.ko.linux                       \
-						 $dir/$driver.ko
-			fi
+			dpkg-divert --package drm-modules-@KERNEL@ --remove --rename \
+				--divert $dir/$driver.ko.linux                       \
+					$dir/$driver.ko
 		done
 		;;
 
diff --git a/debian/preinst.modules.in b/debian/preinst.modules.in
index ceda217..e7c39ca 100644
--- a/debian/preinst.modules.in
+++ b/debian/preinst.modules.in
@@ -8,11 +8,9 @@ dir=/lib/modules/@KERNEL@/kernel/drivers/char/drm
 case "${1}" in
 	install|upgrade)
 		for driver in $drivers; do
-			if [ -e "$dir/$driver.ko" ]; then
-				dpkg-divert --package drm-modules-@KERNEL@ --add --rename \
-					--divert $dir/$driver.ko.linux                    \
-						 $dir/$driver.ko
-			fi
+			dpkg-divert --package drm-modules-@KERNEL@ --add --rename \
+				--divert $dir/$driver.ko.linux                    \
+					$dir/$driver.ko
 		done
 		;;
 
-- 
1.5.6.5

Attachment: signature.asc
Description: Digital signature


Reply to: