[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#511988: xserver-xorg-input-evtouch: fix ARM compiler warnings



Package: xserver-xorg-input-evtouch
Version: 0.8.7-3
Severity: minor
Tags: patch


This patch fixes minor bugs in evtouch that cause warnings on gnu ARM
compiler.

Changes
  o EVTouchRead(), p_mtx_attr, priv : Remove unused symbols.
  o Fix "%0.2x" -> "%.2x" formatting.

Quortech open source packages are available at:
  ftp://ftp.quortech.com/eclipse/deb-packages/

The files associated with xf86-input-evtouch_0.8.7-3quortech3.dsc
implement this patch.

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.22-14-generic
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
# Description: This patch fixes minor bugs in evtouch that cause
#   warnings on gnu ARM compiler.
#
# Changes
#   o EVTouchRead(), p_mtx_attr, priv : Remove unused symbols.
#   o Fix "%0.2x" -> "%.2x" formatting.
#
# Feel free to send comments, critics, suggestions to wuth@acm.org. To
# apply simply change into the toplevel directory of the source to be
# modified and enter: patch -p1 < <PATH_TO_PATCH>
# 
# All patches are available under the GNU GPL, I hope they might be
# useful for you (-:
# - Brett Wuth
#
Index: xf86-input-evtouch-0.8.7/ev_calibrate.c
===================================================================
--- xf86-input-evtouch-0.8.7.orig/ev_calibrate.c	2009-01-14 15:55:48.000000000 -0700
+++ xf86-input-evtouch-0.8.7/ev_calibrate.c	2009-01-14 15:56:19.000000000 -0700
@@ -178,7 +178,6 @@
           Thread-Attributes NULL means default
         */
         pthread_attr_t attr;
-        pthread_mutexattr_t  *p_mtx_attr = NULL;
         min_max_t min_max;
         
 
Index: xf86-input-evtouch-0.8.7/evtouch.c
===================================================================
--- xf86-input-evtouch-0.8.7.orig/evtouch.c	2009-01-14 15:56:17.000000000 -0700
+++ xf86-input-evtouch-0.8.7/evtouch.c	2009-01-14 15:56:37.000000000 -0700
@@ -716,17 +716,6 @@
 
 
 
-static unsigned char
-EVTouchRead(EVTouchPrivatePtr priv)
-{
-        unsigned char c;
-        XisbBlockDuration (priv->buffer, EV_TIMEOUT);
-        c = XisbRead(priv->buffer);
-        return (c);
-}
-
-
-
 static Bool
 EVTouchGetPacket (EVTouchPrivatePtr priv)
 {
@@ -774,7 +763,7 @@
         while (EVTouchGetPacket (priv) == Success)
         {
                 ev = &priv->ev;
-		DBGOUT(2, "EVTouch: %s type:%0.2x code: 0x%0.4x value:%d\n",
+		DBGOUT(2, "EVTouch: %s type:%.2x code: 0x%.4x value:%d\n",
 			__FUNCTION__, ev->type, ev->code, ev->value);
 
 		InputSetScreen(local);
@@ -1287,8 +1276,6 @@
 
 static void
 PostButtonEvent(LocalDevicePtr local, int button, int is_down,int x, int y) {
-EVTouchPrivatePtr priv = (EVTouchPrivatePtr) (local->private);
-
 #if GET_ABI_MAJOR(ABI_XINPUT_VERSION) == 2
  ConvertProc(local,0,2,x,y,0,0,0,0,&x,&y);
 #endif

Reply to: