Bug#382037: Missing programname and PID in syslog-log by PAM

[Alan Coopersmith <Alan.Coopersmith@Sun.COM>]

Julien Cristau wrote:
> It seems that xdm doesn't call openlog(), so the identifier defaults to
> null when pam calls syslog().
> Alan, do you know why the call to openlog() is conditional on
> __OpenBSD__?  I think we should add it on linux too (something like the
> attached patch).

That's the way we inherited it from XFree86 - from looking at their CVS,
this was a set of changes from the OpenBSD team that XFree86 applied for
OpenBSD only even though they were more widely applicable:

 271. xdm updates from the OpenBSD team, including:
       - support for Kerberos IV authentication [enabled only in OpenBSD.cf,
         but could be enabled for other systems by setting HasdKrbIV]
       - use the arc4random(4) random number generator on OpenBSD
       - add a new resource "allowRootLogin", which can be used to disable
         root logins through xdm
       - log failed logins to syslogd [OpenBSD only, but could be enabled on
         other systems]
       - verify that the shell is valid using /etc/shells [OpenBSD only]
       - verify that the account hasn't expired [OpenBSD only, but could be
         enabled on other system that use the same passwd aging structure]
      (#3948, 3980, OpenBSD team, Matthieu Herrb).

I'd have no objections to using openlog() on other OS'es too, though I'd
prefer an autoconf test for the openlog() function over just adding __linux__
(or just making it non-conditional for all OS'es if everyone has openlog()).

-- 
	-Alan Coopersmith-           alan.coopersmith@sun.com
	 Sun Microsystems, Inc. - X Window System Engineering