Re: pre-upload review for xserver-xorg-video-intel
On Sat, Oct 18, 2008 at 18:34:21 +0200, Pierre Habouzit wrote:
> On Sat, Oct 18, 2008 at 02:21:21PM +0000, Julien Cristau wrote:
> > Hi,
> >
> > I've looked at upstream git for fixes that we probably want in the intel
> > X driver for lenny, and pushed what I came up with to [1]. I'd like to
> > get the opinion of some release team member on this before I push to the
> > main repo and upload (review from debian-x people would be welcome too,
> > of course).
> > Changelog entry and diffstat follow, let me know if I should post the
> > diff on the list or if pointing to the git repo works for you.
>
> looking at the changelog and diffstat I'd say that most of it looks
> sane. The line count of the src/i830_dri.c diff looks big though, but oh
> well...
>
Actually, reading the diff again I noticed that one of the changes in
i830_dri.c is to make I830DRIInitBuffers() a no-op, which seems wrong.
I requested clarification from keithp, so I'll wait a bit and either
upload with a fixed commit or revert that one.
Cheers,
Julien
Reply to: