[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#498823: xfs essentially works, so this is not technically RC



severity 498823 important
tag 498823 + patch
thanks

Hi,

some analysis (Congstar/DTAG needs to fix my DSL line, so I had to work
on stuff I remembered):
1) all of xfs essentially works. Logging via syslog does and so does
   pidfile-management by start-stop-daemon,
2) loggging to a file is still enabled in the config file, contrary to
   the comment there, xfs tries to open that even if syslog logging
   is enabled. Attached patch fixes this.
3) xfs tries to remove the pidfile at shutdown which fails (because the
   pidfile is owned by root and xfs is running as nobody) and causes an
   (irritating, but not pointing at a severe issue) log message to be
   printed. Ways to fix this include
   - make the message sound more harmless ("Could not remove pid file,
     hoping that something else does"), or
   - make pidfile a configuration option with permitting to disable
     this.

I'd be happy to NMU this if it helps anyone, prepare a patch that
implements either solution to 3), or both, if Julien wants to give me a
shout.

Kind regards

T.
-- 
Thomas Viehmann, http://thomas.viehmann.net/
Hi,

xfs tries to open the logfile even if it uses syslog (as well).
This diables the logfile in the config file, eliminating the
(confusing but not that important) error message.
The other message (xfs not being able to handle the pid file
by itself) remains but is equally harmless: xfs doesn't need
to be concerned with it's pidfile.
If you want, I can look into adding a config option disabling
xfs's attempt to handle the pidfile, too.

Kind regards

T.

diff -u xfs-1.0.8/debian/changelog xfs-1.0.8/debian/changelog
--- xfs-1.0.8/debian/changelog
+++ xfs-1.0.8/debian/changelog
@@ -1,3 +1,12 @@
+xfs (1:1.0.8-2.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Adjust config file to disable logging to file (Closes: #...).
+    We log to syslog, but with this parameter, xfs tries to open
+    the logfile which fails because we run as nobody.
+
+ -- Thomas Viehmann <tv@beamnet.de>  Thu, 09 Oct 2008 22:32:45 +0200
+
 xfs (1:1.0.8-2) unstable; urgency=low
 
   * Add $syslog dependency to the xfs init.d script (closes: #489232).
diff -u xfs-1.0.8/debian/patches/02_debian_setup.diff xfs-1.0.8/debian/patches/02_debian_setup.diff
--- xfs-1.0.8/debian/patches/02_debian_setup.diff
+++ xfs-1.0.8/debian/patches/02_debian_setup.diff
@@ -8,7 +8,7 @@
 ===================================================================
 --- a/config.cpp.orig	2006-03-07 22:09:01.000000000 -0500
 +++ b/config.cpp	2006-03-07 22:13:53.000000000 -0500
-@@ -1,15 +1,19 @@
+@@ -1,15 +1,20 @@
  XCOMM font server configuration file
  XCOMM $Xorg: config.cpp,v 1.3 2000/08/17 19:54:19 cpqbld Exp $
  
@@ -18,8 +18,10 @@
  clone-self = on
 -use-syslog = off
 -catalogue = DEFAULTFONTPATH
-+XCOMM log messages to FSERRORS (if syslog is not used)
- error-file = FSERRORS
++XCOMM log messages to FSERRORS
++XCOMM (Debian xfs uses syslog by default to run as nobody)
+-error-file = FSERRORS
++XCOMM error-file = FSERRORS
 +XCOMM log errors using syslog
 +use-syslog = on
 +XCOMM turn off TCP port listening (Unix domain connections are still permitted)

Reply to: