Re: Openchrome Package Audit

[Julien Cristau <jcristau@debian.org>]

Hi,

I started reviewing the package, so here are some more comments:
- you have an unused debian/install file
- you tell make install to put files directly in debian/$(PACKAGE)/,
  which also installs libtool's .la files; please use
  DESTDIR=$(CURDIR)/debian/tmp instead, and use
  dh_install --sourcedir=debian/tmp
- the architecture field is too restrictive, there are other x86
  architectures out there; please at least allow hurd-i386 and
  kfreebsd-{i386,amd64}
- you need a build-dep on xserver-xorg-dev (>= 2:1.4) for the serverabi
  stuff
- is the Replaces: xserver-xorg-video-via, xserver-xorg-video-unichrome
  needed?  I don't see any files in the package that conflict with via,
  but I don't know about unichrome

Cheers,
Julien