[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#470940: x11-common: Problem with LSB header in init.d script



Package:  x11-common
Version:  1:7.0.19
Tags:     patch
User:     initscripts-ng-devel@lists.alioth.debian.org
Usertags: incorrect-dependency

I just checked the boot order in unstable on a machine with dependency
based boot sequencing enabled, and discovered a problem with the
init.d scripts provided in the x11-common package.  The script depend
on $remote_fs, while there is nothing as far as I can see that need
more than a mounted /tmp/, which is available with $local_fs.  Also,
it depend on $named while running from rcS.d/.  This do not make
sense, as all $named implementations is executed after rcS.d/ scripts
are executed.  None of these issues are fatal now, but make the boot
ordering less optimal.  IT would become fatal if any of the $named
implementations depend on x11-common.  I'm not aware of any such issue
today.

Here is a patch to solve these issues.

diff -ur xorg-7.3+10.orig/debian/x11-common.init xorg-7.3+10/debian/x11-common.init
--- xorg-7.3+10.orig/debian/x11-common.init     2007-12-04 05:52:57.000000000 +0100
+++ xorg-7.3+10/debian/x11-common.init  2008-03-14 18:07:43.000000000 +0100
@@ -2,10 +2,8 @@
 # /etc/init.d/x11-common: set up the X server and ICE socket directories
 ### BEGIN INIT INFO
 # Provides:          x11-common
-# Required-Start:    $local_fs $remote_fs
-# Required-Stop:     $local_fs $remote_fs
-# Should-Start:      $named
-# Should-Stop:       $named
+# Required-Start:    $local_fs
+# Required-Stop:     $local_fs
 # Default-Start:     S
 # Default-Stop:
 ### END INIT INFO



Reply to: