[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#441902: xserver-xorg-video-ati: 6.7.192-1~7.2 crashes xserver with xv video playback on compiz



On Wed, 2007-09-19 at 19:31 -0400, Alec Robertson wrote:
> 
> Program received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0xb7d6f8c0 (LWP 13498)]
> 0xb7c5d132 in RADEONPutImage (pScrn=0x8216fb0, src_x=<value optimized out>, src_y=<value optimized out>, drw_x=-3740, 
>     drw_y=389, src_w=480, src_h=272, drw_w=480, drw_h=272, id=842094169, 
>     buf=0xa40b1000 ")+++,-.' \036 \"!!!\"! \035\033\033", '\032' <repeats 12 times>, '\031' <repeats 14 times>, "\033 $(
> ))**++++,,++++++++", ',' <repeats 16 times>, '+' <repeats 14 times>, "*****)****,.24688878888998::::::;;;;<<<=>>=;;;<==@
> @AABBBBCDEEFFGGGE=5-\"\035\034\034\034\035\035\035\034\034\034\034\034\033\033\032\033\033\034\035\035\036\036\035\036\0
> 36\037\037\036\036\036"..., width=480, height=272, Sync=0, clipBoxes=0xbfa0de14, data=0x825cc98, pDraw=0x8812b38)
>     at ../../src/radeon_video.c:2910

[...]

>         crtc = (xf86CrtcPtr) 0x0

Does the attached patch fix it?


-- 
Earthling Michel Dänzer           |          http://tungstengraphics.com
Libre software enthusiast         |          Debian, X and DRI developer
diff --git a/src/radeon_video.c b/src/radeon_video.c
index 271f7fe..8560192 100644
--- a/src/radeon_video.c
+++ b/src/radeon_video.c
@@ -215,7 +215,9 @@ radeon_clip_video_helper(ScrnInfoPtr pScrn,
 	    REGION_INIT (pScreen, &crtc_region_local, &crtc_box, 1);
 	    crtc_region = &crtc_region_local;
 	    REGION_INTERSECT (pScreen, crtc_region, crtc_region, reg);
-	}
+	} else
+	    return FALSE;
+
 	*crtc_ret = crtc;
     }
 

Reply to: