Re: xorg-server: Changes to 'debian-unstable'

[David Nusinow <dnusinow@speakeasy.net>]

On Mon, Sep 17, 2007 at 08:19:02AM +0200, Julien Cristau wrote:
> Hi David,
> 
> On Mon, Sep 17, 2007 at 00:21:24 +0000, David Nusinow wrote:
> 
> > @@ -114,10 +114,7 @@ Index: xorg-server/hw/xfree86/common/xf86AutoConfig.c
> >  +            }
> >  +            len = strlen(direntry->d_name);
> >  +            /* A tiny bit of sanity checking. We should probably do better */
> > -+            if (direntry->d_name[len-3] == 'i' && \
> > -+                direntry->d_name[len-2] == 'd' &&  \
> > -+                direntry->d_name[len-1] == 's') { 
> > -+
> > ++            if (strncmp(direntry->d_name[len-4], ".ids", 4) == 0) {
> >  +                /* We need the full path name to open the file */
> >  +                path_name[0] = '\0';
> >  +                strncat(path_name, "/usr/share/xserver-xorg/pci/", 256);
> 
> This should be strncmp(direntry->d_name + len - 4, ".ids", 4).

Yeah, I caught this later. The fix should be in git already.

 - David Nusinow