[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#425445: libx11-6: fails to cross-build. tries to run cross-built makekeys utility



On Sun, 12 Aug 2007 22:58:48 +0200
Julien Cristau <jcristau@debian.org> wrote:

> > > -#override CC = gcc
> > > -LINK = $(CC) $(AM_CFLAGS) $(CFLAGS) $(AM_LDFLAGS) $(LDFLAGS) -o $@
> > > +CC = @CC_FOR_BUILD@
> > 
> > I could not get that to work.
> > 
> > A working patch, based on the above, is attached, using the 'override'
> > command to 'make'.
> > 
> The override command is gnu make specific, so that's not a good
> solution.

Which is preferable:
1. Require GNU make to cross-build, or
2. Hardcode gcc into a series of *manual* make rules in src/utils/
3. find a different way to generate the makekeys output
?

I could envisage a method in this part of debian/rules:

ifeq ($(DEB_BUILD_GNU_TYPE), $(DEB_HOST_GNU_TYPE))
	confflags += --build=$(DEB_HOST_GNU_TYPE)
else
	confflags += --build=$(DEB_BUILD_GNU_TYPE) --host=$(DEB_HOST_GNU_TYPE)
	# add emdebian patch to quilt here
endif

Presumably, quilt can be used to add 023_gnu_cross.diff (renamed to
indicate cross-building only and reliance on GNU make?) to the patch
series only if cross-building? (I don't use quilt much.)

This way, the override command would only be used if cross-building the
Debian package so we can be fairly sure that GNU make is being used.
Certainly, Emdebian will be using GNU make.

OK, it means the patch can't go upstream but if debian/rules can
arrange to add the patch (via quilt) only when cross-building, I'd be
happy with that.

-- 


Neil Williams
=============
http://www.data-freedom.org/
http://www.nosoftwarepatents.com/
http://www.linux.codehelp.co.uk/

Attachment: pgpT6Txz56w9z.pgp
Description: PGP signature


Reply to: