[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#420974: xterm: Bug is not fixed, because KOI8-R is not only one cyrillic charset.



On Fri, Jun 29, 2007 at 08:00:15PM +0200, Yauhen Kharuzhy wrote:
> Package: xterm
> Version: 226-1
> Followup-For: Bug #420974
> 
> 
> I use locales ru_RU.CP1251 and be_BY.CP1251, CP1251 is another cyrillic
> charset, and this bug still exists for me and many users from ex-USSR.
> Additionaly, another one-byte charsets exist, not only for cyrillic
> symbols, and fixing this bug for KOI8-R users only is error.

iirc, all of those use printable C1 (128-159 codes), so the fix noted in
the changes should apply:

     * amend select/paste change from patch #225 by limiting it to
       non-UTF-8/non-KOI8-R encoding (Debian #420974).
 
since the internal check for the "non-KOI8-R" only checks if the
allowC1Printable resource is set (the "-k8" option).

Here's the related chunk in xterm's button.c:

@@ -1611,7 +1611,8 @@
            GettingSelection(dpy, *type, line, *length);

 #if OPT_WIDE_CHARS
-           if (*type == XA_UTF8_STRING(dpy)) {
+           if (*type == XA_UTF8_STRING(dpy) &&
+               !(screen->wide_chars || screen->c1_printable)) {
                rc = Xutf8TextPropertyToTextList(dpy, &text_prop,
                                                 &text_list, &text_list_count);
                if (text_list != NULL && text_list_count != 0) {

Some KOI8-R users don't use the option, but that's never been supported.

p.s: before reporting a bug not fixed, try testing it.

-- 
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net

Attachment: pgpsrZlMvMa_k.pgp
Description: PGP signature


Reply to: