[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#422678: Bug#422666: FTBFS: ../../src/xf86Calcomp.c:682: error: 'TS_Raw' undeclared



Notes:  TS_Raw and friends were removed from XI.h in commit
7a4a2a3e733378abced0a184627adfda4ed387b9, 17 Jul 2006 by Daniel Stone.

The commit comment was
"add DevicePresenceNotify event, clean up

Add DevicePresenceNotify event, which indicates that something in the
device list changed (Kristian Høgsberg, Red Hat).
Add a core event control, which toggles the sending or not of core
events by an extended device.
Clean up some random detritus from the MetroLink merge."


That last comment implies that penmount should never have been using
TS_Raw in the first place?



TS_Raw entered XI.h in commit 4383a95e0bbc2f09394deefc453c2edd1c813d0f,
14 Nov 2003 by Kaleb Keithley.
"XFree86 4.3.0.1"

... comes from old old history, it seems.



Usage appears in xf86PM.c:389:
        s = xf86FindOptionValue (pInfo->options, "ReportingMode");
        if ((s) && (xf86NameCmp (s, "raw") == 0))
                priv->reporting_mode = TS_Raw;
       else
                priv->reporting_mode = TS_Scaled;

priv is a PenMountPrivatePtr.

priv->reporting_mode is used in l.598:

if (priv->reporting_mode == TS_Scaled)                             
             {                                                                  
                     x = xf86ScaleAxis (x, 0, priv->screen_width, priv->min_x,  
                                        priv->max_x);                           
                     y = xf86ScaleAxis (y, 0, priv->screen_height, priv->min_y, 
                                        priv->max_y);                           
             } 

So it is intimately bound into the internals of the penmount driver.
Therefore not trivial to fix.  

Anyway, Daniel knows about the problem. Not high on his priority list.
https://bugs.freedesktop.org/show_bug.cgi?id=10262

Drew



Reply to: