[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#331213: marked as done (please lower priority of display mode question)

Your message dated Tue, 22 May 2007 20:26:04 +0200
with message-id <465335BC.5060601@ens-lyon.org>
and subject line Bug#331213: please lower priority of display mode question
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)
--- Begin Message --- 
Package: xserver-xorg
Version: 6.8.2.dfsg.1-6
Severity: wishlist
Tags: patch

According to debconf specification [1], "high" priority is for items that don't
have a reasonable default.  The debconf debconf template says "high" is for
rather important questions.  IMHO, this doesn't apply to the resolution question
and the priority should be lowered to "medium".

This problem is specialy relevant when using the /etc/init.d/xserver-xorg
script.  On a livecd, user will be asked for the resolution on every boot
which is often not wanted (this is the case for Ging [2]).  I think the only
essential questions for a livecd are video driver (in case vesa/vga don't work)
and mice (in case auto-detection failed).

As for reasonable defaults, I think the current default (1024x768, 800x600,
640x480) is quite reasonable, but I would recommend using an empty list as
default instead.

In case you agree with both lowering the priority, and using an empty list as
default, you can use the patch I'm attaching.

Thanks!

[1] http://www.debian.org/doc/packaging-manuals/debconf_specification.html#AEN103
[2] http://glibc-bsd.alioth.debian.org/ging/

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11-1-k7
Locale: LANG=en_US, LC_CTYPE=en_US (charmap=ANSI_X3.4-1968) (ignored: LC_ALL set to C)

Versions of packages xserver-xorg depends on:
ii  debconf [debconf-2.0]     1.4.58         Debian configuration management sy
ii  libc6                     2.3.5-6        GNU C Library: Shared libraries an
ii  libgcc1                   1:4.0.1-6      GCC support library
ii  libxau6                   6.8.2.dfsg.1-6 X Authentication library
ii  libxdmcp6                 6.8.2.dfsg.1-6 X Display Manager Control Protocol
ii  xserver-common            6.8.2.dfsg.1-6 files and utilities common to all 
ii  zlib1g                    1:1.2.3-4      compression library - runtime

Versions of packages xserver-xorg recommends:
ii  discover1                 1.7.13         hardware identification system
pn  laptop-detect             <none>         (no description available)
pn  mdetect                   <none>         (no description available)
ii  xlibs                     6.8.2.dfsg.1-6 X Window System client libraries m
pn  xresprobe                 <none>         (no description available)

-- debconf information excluded

diff -ur xorg-x11-6.8.2.dfsg.1/debian.old/xserver-xorg.postinst.in xorg-x11-6.8.2.dfsg.1/debian/xserver-xorg.postinst.in
--- xorg-x11-6.8.2.dfsg.1/debian.old/xserver-xorg.postinst.in	2005-09-26 20:56:43.000000000 +0200
+++ xorg-x11-6.8.2.dfsg.1/debian/xserver-xorg.postinst.in	2005-09-26 20:53:23.000000000 +0200
@@ -355,7 +355,6 @@
   # Resolution hell:
   # we need to know if we probed resolutions, if so add them to debconf template
   # as choices, so that we don't lose them across updates or reconfiguration.
-  PRIORITY=high
   if [ -z "$NOPROBE" ]; then
     NRES=0
     for i in $RESOLUTIONS; do
@@ -364,7 +363,6 @@
 
     if [ "$NRES" -gt "0" ]; then
       # got RESOLUTIONS. Lower question priority
-      PRIORITY=medium
       DCRESOLUTIONS=$(for i in $DCRESOLUTIONS $RESOLUTIONS; do echo $i; done | sort -unr)
       DCRESOLUTIONS=$(echo $DCRESOLUTIONS | sed -e 's/ /, /g')
     fi
@@ -382,11 +380,6 @@
     fi
   fi
 
-  if [ -z "$RECONFIGURE" ] && [ -z "$FIRSTINST" ]; then
-    # drop priority on upgrades
-    PRIORITY=medium
-  fi
-
   db_metaget xserver-xorg/config/display/modes choices
   if [ -n "$RET" ]; then
     DCRESOLUTIONS="$RET"
@@ -404,7 +397,7 @@
     RESOLUTIONS=$(echo $RESOLUTIONS | sed -e 's/ /, /g')
     db_set xserver-xorg/config/display/modes "$RESOLUTIONS"
   fi
-  db_input $PRIORITY xserver-xorg/config/display/modes || true
+  db_input medium xserver-xorg/config/display/modes || true
   db_go
 
   db_subst xserver-xorg/config/monitor/selection-method choices "Simple, Medium, Advanced"
diff -ur xorg-x11-6.8.2.dfsg.1/debian.old/xserver-xorg.templates xorg-x11-6.8.2.dfsg.1/debian/xserver-xorg.templates
--- xorg-x11-6.8.2.dfsg.1/debian.old/xserver-xorg.templates	2005-09-26 20:42:15.000000000 +0200
+++ xorg-x11-6.8.2.dfsg.1/debian/xserver-xorg.templates	2005-09-26 20:53:23.000000000 +0200
@@ -487,7 +487,6 @@
 Template: xserver-xorg/config/display/modes
 Type: multiselect
 Choices: ${choices}
-Default: 1024x768, 800x600, 640x480
 _Description: Select the video modes you would like the X server to use.
  If there are some resolutions you would not like the X server to use even if
  your hardware is capable of them, remove them from the list below.  Removing

--- End Message ---
--- Begin Message --- 
Closing since we do not ship any /etc/init.d/xserver-xorg anymore.

Brice

--- End Message ---
Reply to: