[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#418098: rdesktop segfault with libx11-6 1.0.3-7



On Fri, Apr  6, 2007 at 15:30:00 -0400, Eric Covener wrote:

> Package: rdesktop
> Version: 1.5.0-1
> 
> rdesktop crashes right after successful windows login with libx11-6 1.0.3-7 
> ,
> no crashes when downgrading libx11 to libx11-6 1.0.3-6
> 
> I am running unstable on an ia32 system
> 
I guess this happens because rdesktop calls XCreateImage() with an
invalid value for the bytes_per_line parameter, and doesn't check the
return value.  Since the latest update, libx11 does sanity checks on
this parameter, and XCreateImage() returns NULL.  Since rdesktop never
checks the value returned by this function, it segfaults.

rdesktop probably assumes that bytes_per_line is related to depth*width,
instead of bpp*width, so it should either fix that or use a value of
bytes_per_line of 0, which lets Xlib calculate the correct value.

See http://bugs.freedesktop.org/show_bug.cgi?id=10536 ,
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=418016 and
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=418021 .

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: