[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#412069: patch for beryl support



On Fri, Feb 23, 2007 at 12:18:06PM +0100, Robert Millan [ackstorm] wrote:
> Package: xserver-xorg
> Severity: wishlist
> Tags: patch
> 
> I know it's too late for Beryl to make it into etch, but can we at least ship
> an xorg.conf that is frendly to Beryl ?  With this patch, only installing
> the beryl packages will be enough to get it working with no further setup
> (provided that OpenGL is working fine).
> 
> Also note that having these extra lines in your xorg.conf is harmless for
> non-Beryl users (at least it didn't produce any new warnings or errors in
> /var/log/Xorg.log for me), so I propose to add them unconditionaly.
> 
> Please, can this make it into etch?  This kind of eye-candy is _awesome_
> to attract new users.
> 
> -- 
> Robert Millan
> 
> ACK STORM, S.L.  -  http://www.ackstorm.es/

> diff -ur xorg-7.1.0.old/debian/local/dexconf xorg-7.1.0/debian/local/dexconf
> --- xorg-7.1.0.old/debian/local/dexconf	2007-02-13 11:02:09.000000000 +0100
> +++ xorg-7.1.0/debian/local/dexconf	2007-02-23 12:07:45.000000000 +0100
> @@ -351,6 +351,11 @@
>  if [ "$DEVICE_USE_FBDEV" = "true" ]; then
>    printf "\tOption\t\t\"UseFBDev\"\t\t\"$DEVICE_USE_FBDEV\"\n" >&4
>  fi
> +cat >&4 <<SECTION
> +	# needed for beryl
> +	Option		"XAANoOffscreenPixmaps" "true"
> +	Option		"AddARGBGLXVisuals" "On"

These aren't generally necessary, and I don't believe it's a good idea to
set them as default when they're not needed. The latter may be harmless,
but I don't know enough about the former, since it only appears to be
useful on some ati hardware. There's a reason why upstream hasn't enabled
it by default in the driver.

> +SECTION
>  printf "EndSection\n" >&4
>  
>  ### MONITOR
> @@ -428,6 +433,15 @@
>  EndSection
>  SECTION
>  
> +### Extensions
> +exec 4>"$DEXCONFTMPDIR/Extensions"
> +cat >&4 <<SECTION
> +Section "Extensions"
> +	# needed for beryl
> +	Option		"Composite" "Enable"
> +EndSection
> +SECTION

I haven't decided if enabling composite by default is a wise move yet. No
one in Debian has done a real analysis as to what the downsides of such a
decision are.

While compiz and beryl may be very sexy, I don't want to break or degrade
performance on systems not running them simply for the convenience of not
having to modify xorg.conf. It's not out of the question, but I don't want
to blindly enable options in our default settings for the bling of it.

 - David Nusinow



Reply to: