Bug#301531: [radeon] Lockup when using Hyperball screensaver
On Sat, 2007-01-20 at 00:22 +0100, Dimitri Chausson wrote:
> On Fri, 19 Jan 2007 08:24:37 +0100
> Michel Dänzer <daenzer@debian.org> wrote:
>
> > On Fri, 2007-01-19 at 00:49 +0100, Dimitri Chausson wrote:
> > >
> > > - the other advice (comment #12) does not apply for me, since
> > > the options do not appear in my configuration file (
> > > "XaaNoSolidBresenhamLine" and "XaaNoSolidTwoPointLine" )
>
> adding the options in combination with DRI loaded works. There
> is no crash anymore. The animation is just slower, but I guess
> it is a consequence of turning off things (with the options).
Right. Can you try the attached patch without these options?
--
Earthling Michel Dänzer | http://tungstengraphics.com
Libre software enthusiast | Debian, X and DRI developer
diff --git a/src/radeon_accelfuncs.c b/src/radeon_accelfuncs.c
index 784b074..212131f 100644
--- a/src/radeon_accelfuncs.c
+++ b/src/radeon_accelfuncs.c
@@ -1204,8 +1204,14 @@ FUNC_NAME(RADEONAccelInit)(ScreenPtr pScreen, XAAInfoRecPtr a)
hardware accel two point lines */
miSetZeroLineBias(pScreen, (OCTANT5 | OCTANT6 | OCTANT7 | OCTANT8));
- a->SubsequentSolidTwoPointLine
- = FUNC_NAME(RADEONSubsequentSolidTwoPointLine);
+#ifdef ACCEL_CP
+ /* RV280s lock up with this using the CP for reasons to be determined.
+ * See https://bugs.freedesktop.org/show_bug.cgi?id=5986 .
+ */
+ if (info->ChipFamily != CHIP_FAMILY_RV280)
+#endif
+ a->SubsequentSolidTwoPointLine
+ = FUNC_NAME(RADEONSubsequentSolidTwoPointLine);
/* Disabled on RV200 and newer because it does not pass XTest */
if (info->ChipFamily < CHIP_FAMILY_RV200) {
Reply to: