Bug#392498: Bug#278312: xserver-xfree86: [palmax] Touchscreen packets not processed unless under high load
(followup to bug #278312)
Yann Vernier wrote:
> I rarely use that machine anymore, but if I recall correctly I did
> about six months ago, and had to reapply the fix when I upgraded X.
> It's probably easier to check the code to see if the logic error is
> still there (not processing a packet unless *more* data is present).
> I can recheck it if you want, but not today.
I just saw that you reported the same bug against
xserver-xorg-input-palmax in #392498 and posted a clean patch there. We
won't fix xserver-xfree86 anymore. So let's just close this bug and keep
working on the other one. From what I see at:
http://gitweb.freedesktop.org/?p=xorg/driver/xf86-input-palmax.git;a=summary
upstream did not change since the one you have (Xorg 7.0/Palmax
1.0.0.5). So I don't expect the bug to be fixed in 7.1/1.1.0. So I guess
we should apply your patch. I forwarded the bug and patch upstream at
https://bugs.freedesktop.org/show_bug.cgi?id=9690. We'll see what happens.
Brice
---
src/xf86Palmax.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: xserver-xorg-input-palmax-1.1.0/src/xf86Palmax.c
===================================================================
--- xserver-xorg-input-palmax-1.1.0.orig/src/xf86Palmax.c 2007-01-17 19:28:17.000000000 +0100
+++ xserver-xorg-input-palmax-1.1.0/src/xf86Palmax.c 2007-01-17 19:57:06.000000000 +0100
@@ -29,7 +29,7 @@
#define DEFAULT_MAX_Y 61592
#define DEFAULT_MIN_Y 7608
-#define XI_STYLUS "TOUCHSCREEH" /* X device name for the stylus device */
+#define XI_STYLUS "TOUCHSCREEN" /* X device name for the stylus device */
/*
@@ -302,7 +302,7 @@
bytes_in_packet = 0;
start_ptr = ptr;
- while (num_bytes >= report_size)
+ while (num_bytes+bytes_in_packet >= report_size)
{
/*
* Skip bytes until we hit a header (FE/FF)
Reply to: