[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#398289: Copying address into in6_addr instead of in6_addr.sin6_addr in forward_respond().



Package: xdm
Version: 1.0.5-1
Tags: upstream ipv6

In forward_respond(), when filling in6_addr structure,
clientAddress.data is copied into sockaddr_in6 structure instead of its
sin6_addr member.  As a result, xdm fails to respond to ForwardQuery
received over IPv6 connection.

I submitted it to the X.Org's Bugzilla:
https://bugs.freedesktop.org/show_bug.cgi?id=8995.

--- xdm-1.0.5.orig/xdmcp.c      2006-11-12 22:09:00.956646548 +0300
+++ xdm-1.0.5/xdmcp.c   2006-11-12 22:10:39.258790052 +0300
@@ -801,7 +801,7 @@
                    in6_addr.sin6_len = sizeof(in6_addr);
 #endif
                    in6_addr.sin6_family = AF_INET6;
-                   memmove(&in6_addr,clientAddress.data,clientAddress.length);
+                   memmove(&in6_addr.sin6_addr,clientAddress.data,clientAddress.length);
                    memmove((char *) &in6_addr.sin6_port, clientPort.data, 2);
                    client = (struct sockaddr *) &in6_addr;
                    clientlen = sizeof (in6_addr);
-- 
Best regards,	    kent@comintern.ru          My GPG key is
Vickenty Fesunov    http://kent.comintern.ru   0x546defd6 at pgp.mit.edu




Reply to: