[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#388998: xserver-xorg-video-tdfx: Missing include headers



tags 388998 patch
thanks

Hi,

The problem here is that xserver-xorg-video-tdfx is lacking some
included headers, and the getsecs macro does not get expanded, so
module ends up with an unresolvable symbol which makes X crash.
The error can only be seen on the console.

Attached a patch which can be imported into the quilted package. It
fixes a missing header for the abs function as well.

regards,
guillem
Index: xserver-xorg-video-tdfx-1.2.1/src/tdfx_driver.c
===================================================================
--- xserver-xorg-video-tdfx-1.2.1.orig/src/tdfx_driver.c	2006-09-24 05:07:32.000000000 +0300
+++ xserver-xorg-video-tdfx-1.2.1/src/tdfx_driver.c	2006-09-24 05:03:09.000000000 +0300
@@ -46,6 +46,8 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN
  * Overlay planes
  */
 
+#include <stdlib.h>
+
 /*
  * These are X and server generic header files.
  */
Index: xserver-xorg-video-tdfx-1.2.1/src/tdfx_priv.c
===================================================================
--- xserver-xorg-video-tdfx-1.2.1.orig/src/tdfx_priv.c	2006-09-24 05:07:16.000000000 +0300
+++ xserver-xorg-video-tdfx-1.2.1/src/tdfx_priv.c	2006-09-24 04:56:41.000000000 +0300
@@ -4,11 +4,13 @@
 #include "config.h"
 #endif
 
+#include "tdfx.h"
+
 #include "xf86.h"
+#include "xf86_ansic.h"		/* For getsecs() */
 #include "xf86_OSproc.h"
 #include "xf86fbman.h"
 #include "compiler.h"
-#include "tdfx.h"
 
 /*
   Memory layout of card is as follows:

Reply to: