[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#363517: xorg-server and kfreebsd



On Mon, Aug 28, 2006 at 01:55:26PM +0200, Michael Banck wrote:
> Samuel Thibault sent in a patch in #358015 and upstream #5613 for the
> kdrive issue.  The byteswap part should be taken from Petr's patch, as
> it is more general (__GLIBC__ vs. __GNU__, so working on kfreebsd as
> well).

I'm not entirely satisfied with that patch for a few reasons: firstly,
the AM_CONDITIONAL placement is wrong (it should never be in an if; set
a variable you need in an if and put the AM_CONDITIONAL on the outer),
and secondly, we need to reject compilation of 'real' servers at
configure time if we don't have an OS lib for things like VT switching,
keyboard handling ... you know, the little things. ;)

The byteswap bit looks fine though.

Cheers,
Daniel

Attachment: signature.asc
Description: Digital signature


Reply to: