Bug#383918: FTBFS on non-DRM systems

[Samuel Thibault <samuel.thibault@ens-lyon.org>]

Daniel Stone, le Sun 20 Aug 2006 21:07:55 +0300, a écrit :
> > diff -ur xserver-xorg-video-i810-1.6.5/src/brw_structs.h xserver-xorg-video-i810-1.6.5-hurd/src/brw_structs.h
> > --- xserver-xorg-video-i810-1.6.5/src/brw_structs.h	2006-08-08 22:51:25.000000000 +0000
> > +++ xserver-xorg-video-i810-1.6.5-hurd/src/brw_structs.h	2006-08-20 17:23:05.000000000 +0000
> > @@ -28,6 +28,8 @@
> >  #ifndef BRW_STRUCTS_H
> >  #define BRW_STRUCTS_H
> >  
> > +#include <GL/gl.h>
> > +
> >  /* Command packets:
> >   */
> >  struct header 
> 
> This should be guarded with #ifdef XF86DRI (or whatever), and so should
> the relevant struct members.

Mmmm, _all_ structures use GL types. So including GL/gl.h
unconditionnally seems reasonable to me.

> Or it just shouldn't be included if the
> whole file is GL-specific.

Well, in such case it should be added in from of every inclusion of
brw_structs.h, since this file always uses GL*int* types.

Samuel