[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#380061: dpkg-reconfigure xserver-xorg doesn't update /etc/X11/xorg.conf



On Thu, Jul 27, 2006 at 10:35:15AM +0200, Christoph Pfister wrote:
> Reconfiguring xserver-xorg doesn't change /etc/X11/xorg.conf at all because of 
> an obvious error in the postinst script. Please find a patch attached (and 
> hopefully you agree on it ;-) which fixes the bug.

> --- xserver-xorg.postinst_old	2006-06-12 05:46:09.000000000 +0200
> +++ xserver-xorg.postinst	2006-07-27 10:26:19.000000000 +0200
> @@ -1666,7 +1666,7 @@ else
>  fi
>  
>  # here's a novel concept: DON'T TOUCH THE CONFIG ON UPGRADES
> -if [ -z "$UPGRADE" ] || dpkg --compare-versions "$2" le "1:7.0.14"; then
> +if [ -z "$UPGRADE" ] || dpkg --compare-versions "$2" le "$SOURCE_VERSION"; then
>    # compare the current and stored checksums; if they do not match, assume
>    # that's the way the user wants it.  if we're reconfiguring, overwrite
>    # it regardless and back it up.

Nope, the problem is that $UPGRADE is non-zero on reconfigures; I think
there's a patch around already for this.  Your patch would ensure that
the behaviour was exactly contrary to the comment, and would always be
true AIUI.

Attachment: signature.asc
Description: Digital signature


Reply to: