[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#373949: xlibmesa-dri: [ati/r128] r128_cce_depth called without lock held



Package: xlibmesa-dri

Ok, I think I've finally narrowed it down. The R128_DEBUG messages were
a red-herring. The bug appears to be in:

Mesa-6.4.2/src/mesa/drivers/dri/r128/r128_span.c

If you look at lines 80 and 82, you see that HW_LOCK() and HW_UNLOCK()
are defined to be blank. However,if you look further down to the
manipulations of the depth buffer (line 117 for example) you see it
calls r128WriteDepthSpanLocked(), which assumes the device is locked.

It would seem that the fix is to merely at line 114 to #undef HW_LOCK
and HW_UNLOCK, restoring the normal definitions which actually lock the
device.

Who is the right person to talk to about this? If it really is this
simple I may be able to try compiling with the change and test it. But
it would be nice to find someone knowledgable to look at this.

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog@svana.org>   http://svana.org/kleptog/
> From each according to his ability. To each according to his ability to litigate.



Reply to: