On Fri, May 05, 2006 at 10:30:31AM +0200, Vincent Lefevre wrote: > On 2006-05-04 18:02:31 -0700, Steve Langasek wrote: > > Yes, it says that local changes must be preserved; it does not say > > that the package may not attempt to upgrade config files. > If it attempts to upgrade something the user has changed, this isn't > much different. Moreover the /etc/X11/xorg.conf says: > # This file is automatically updated on xserver-xorg package upgrades *only* > # if it has not been modified since the last upgrade of the xserver-xorg > # package. > So, with the latest upgrade, this was plainly wrong. Heh, true. > > The possible fontpath duplication for users who had already upgraded > > to modular was a known issue when this handling was put in place, > > but this consideration was secondary to the need to provide upgrade > > handling for all the users being left without font support. > There could be a dialog box to ask the user if he wanted to update the > config file. Also, the upgrade script could check if new paths were > already added. I don't think this should be a dialog box, but yes, the upgrade script could (and should) check for the new paths before it re-adds them. I don't disagree with you that the script's behavior in this case is wrong, but since it's not actually a policy violation (by my reading at least), and it doesn't break your system, and it really only affects the small slice of users who had both upgraded to X11R7 in unstable *and* hand-updated the FontPaths in their xorg.conf, it's definitely an improvement over what we had before... > > Does this duplication cause any problems for you, or is it merely > > cosmetic? > This adds useless bloat to the config file and to diffs (when one > tracks diffs of config files, e.g. with diffmon), making it more > difficult to maintain. Fair enough. FWIW, I would tend to classify both of those as "cosmetic" issues. :) Cheers, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. vorlon@debian.org http://www.debian.org/
Attachment:
signature.asc
Description: Digital signature