[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: X Strike Force X.Org X11 SVN commit: r2097 - trunk/debian/xorg/debian



On Thu, May  4, 2006 at 22:55:38 -0400, X Strike Force SVN Repository Admin wrote:

> Author: dnusinow
> Date: 2006-05-04 22:55:36 -0400 (Thu, 04 May 2006)
> New Revision: 2097
> 
> Log:
> * Tell the configuration scripts that we're upgrading properly. The variable
>   that was being used to test this was never set for some reason.
> 
> Modified: trunk/debian/xorg/debian/x11-common.postinst.in
> ===================================================================
> --- trunk/debian/xorg/debian/x11-common.postinst.in	2006-05-05 02:16:37 UTC (rev 2096)
> +++ trunk/debian/xorg/debian/x11-common.postinst.in	2006-05-05 02:55:36 UTC (rev 2097)
> @@ -59,15 +59,15 @@
>  
>  # only mess with config file it exists; otherwise, assume that's the way the
>  # user wants it, but only if upgrading
> -if [ -e "$XWRAPPER_CONFIG" ] || [ -z "$UPGRADE" ]; then
> +if [ -e "$XWRAPPER_CONFIG" ] || [ -n "$2" ]; then

Hi,

wasn't the UPGRADE variable supposed to be non-empty on upgrades?
If so, [ -z "$UPGRADE" ] is true when we're *not* upgrading, whereas
[ -n "$2" ] will be true on upgrades, so the test is backwards.
If I'm mistaken about the semantics of $UPGRADE, then please disregard
this message.

Cheers,
Julien

Attachment: signature.asc
Description: Digital signature


Reply to: