[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#365967: x11-common: unnecessary use of pre-depends (354146)



Package: x11-common
Version: 1:7.0.16
Severity: important

The latest version of x11-common now pre-depends on xfree86-common,
nominally in order to fix bug #354146.  The rationale given for the
pre-depends in that bug is incorrect:

  Hmm, then x11-common Pre-Depends: xfree86-common to make sure that
  xfree86-common.postinst is run before x11-common is configured,
  shouldn't it?  Or maybe remove the conffile in xfree86-common.preinst?

<http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=354146;msg=34>

Please review the definitions of Depends and Pre-Depends in Policy.  "A
configured before B configured" is satisfied by a simple Depends, a
Pre-Depends is only required if A must be configured before B is *unpacked*.
Constraining the unpack order of packages in this fashion, when it isn't
actually required, makes for brittle upgrades.

Pre-Depends are also not supposed to be added to packages without first
discussing them on -devel...

BTW, some other conffile that was moved from one package to another as part
of the modular switch apparently moved just fine (i.e., without conffile
prompts, whether or not it was modified) just by setting Conflicts/Replaces
against the old package.  Does anyone understand why this worked in the
other case, but not in this one?

Actually, can anyone even confirm that this bug was reproducible with
x11-common 1:7.0.14/15?  The bug was *filed* against version 1:7.0.0, but
the bug log only shows the output of upgrading to x11-common 6.9.0.dfsg.1-4.
Does that version predate the addition of the xfree86-common conflicts?

-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/

Attachment: signature.asc
Description: Digital signature


Reply to: