[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#347790: xterm: boldMode patch



On Sun, 19 Mar 2006, Tim Pope wrote:

Hi, thanks for the feedback!

On Sun, Mar 19, 2006 at 09:24:46AM -0500, Thomas Dickey wrote:
I agree that it should do what you're describing, but the patch is applied
before xterm has found the data that it needs to do the boldMode feature.
For instance, on the next line (see the context of the patch) it checks to
see if it was able to derive a bold font specifier.  Later it checks if
that was different from the normal (or font1, etc) font.

I see some problems with my previous approach, most notably a
potential memory leak I'm not sure how I missed.  Here's a second
attempt.  Perhaps you can tell me if I'm on the right track.  Is this
how you would go about it?

That looks better. Essentially what you want is to make boldMode disable the bold font. It would be nice in that case to add a menu entry under VT Fonts to turn that on/off - which opens up a new set of issues - perhaps I'll do that for #212 (am closing out #211 tonight).

--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net



Reply to: