[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#349318: libxft-dev: please do not export unnecessary libraries in xft.pc



Package: libxft-dev
Version: 2.1.7-1
Severity: important
Tags: upstream

Hi folks,

So, I suppose most of you have read
<http://lists.debian.org/debian-devel-announce/2005/11/msg00016.html> about
problems with packages depending on libraries that they don't use,
particularly as relates to a potential libfreetype transition.  One library
that currently exposes freetype (and other libs) in its pkg-config .pc file,
but shouldn't, is libxft.

Please consider (and forward upstream) the attached patch which moves all of
the library dependencies of libxft into the Libs.private variable in xft.pc,
so that they aren't used on Debian except for static linking.  I have not
touched the 'Requires' field; even though packages which link to libXft
should not need to link to libfontconfig, the pkg-config 'Requires' field
controls both CPPFLAGS and LDFLAGS, and Xft includes fontconfig headers --
unfortunately the pkg-config maintainer has not been convinced that CPPFLAGS
from Requires.private should be propagated, despite the fact that there are
many examples of this scenario in Debian... (this is bug #340904, for those
who care.)

FWIW, since September 2003 FreeType has supported pkg-config; however, I
wouldn't recommend that Xft use pkg-config dependencies for libfreetype
unless this Requires.private CPPFLAGS issue is resolved. :/

Oh, also, there seems to be a pre-existing bug in this .pc file, in that
-lX11 is specified for static linking, but -L/usr/X11R6/lib is not...

Thanks,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
vorlon@debian.org                                   http://www.debian.org/
diff -u xft-2.1.7/debian/changelog xft-2.1.7/debian/changelog
--- xft-2.1.7/debian/changelog
+++ xft-2.1.7/debian/changelog
@@ -1,3 +1,11 @@
+xft (2.1.7-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix xft.pc to not export freetype and xrender as part of the interface
+    used for shared linking; expose them only in Libs.private instead.
+
+ -- Steve Langasek <vorlon@debian.org>  Sun, 22 Jan 2006 02:32:25 -0800
+
 xft (2.1.7-1) unstable; urgency=low
 
   * New upstream release.
only in patch2:
unchanged:
--- xft-2.1.7.orig/xft.pc.in
+++ xft-2.1.7/xft.pc.in
@@ -11,5 +11,6 @@
 Description: X FreeType library
 Version: @VERSION@
 Requires: fontconfig
-Libs: -L${libdir} -lXft -lX11 ${freetypelibs} ${xrenderlibs}
+Libs: -L${libdir} -lXft
+Libs.private: -lX11 ${freetypelibs} ${xrenderlibs}
 Cflags: -I${includedir} ${freetypecflags} ${xrendercflags}

Attachment: signature.asc
Description: Digital signature


Reply to: