Bug#307216: marked as done (xterm colorization problems)
Your message dated Wed, 3 Aug 2005 01:54:45 +0200
with message-id <200508030154.52151.ender@debian.org>
and subject line Bug#307216: #307216: xterm colorization problems
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 1 May 2005 20:04:48 +0000
>From sithglan@stud.uni-erlangen.de Sun May 01 13:04:48 2005
Return-path: <sithglan@stud.uni-erlangen.de>
Received: from faui03.informatik.uni-erlangen.de [131.188.30.103]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DSKgJ-0005ca-00; Sun, 01 May 2005 13:04:47 -0700
Received: from faui00u.informatik.uni-erlangen.de (sithglan@faui00u.informatik.uni-erlangen.de [131.188.30.59])
by faui03.informatik.uni-erlangen.de (8.12.9/8.12.9) with ESMTP id j41K4jS8020232
(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO)
for <submit@bugs.debian.org>; Sun, 1 May 2005 20:04:46 GMT
Received: (from sithglan@localhost)
by faui00u.informatik.uni-erlangen.de (8.13.4/8.12.3/Debian-8) id j41K4jXt001908;
Sun, 1 May 2005 22:04:45 +0200
Message-Id: <200505012004.j41K4jXt001908@faui00u.informatik.uni-erlangen.de>
X-Authentication-Warning: faui00u.informatik.uni-erlangen.de: sithglan set sender to sithglan@stud.uni-erlangen.de using -f
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: xterm colorization problems
X-Mailer: reportbug 3.8
Date: Sun, 01 May 2005 22:04:45 +0200
X-Debbugs-Cc: dickey@his.com
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-11.0 required=4.0 tests=BAYES_00,HAS_PACKAGE,
X_DEBBUGS_CC autolearn=ham version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: xterm
Version: 4.3.0.dfsg.1-12.0.1
Severity: important
Tags: patch
Xterm has some colorization problems which are pop-up for example if you
read your eMail in mutt in a screen. The problem is:
From: Thomas Dickey <dickey@his.com>
To: Thomas Glanzmann <sithglan@stud.uni-erlangen.de>
Subject: Re: Color problems with xterm-201
Date: Sun, 1 May 2005 15:31:09 -0400
I found the problem (took about an hour). It was when xterm was writing
out pending data, updated the display's colors and didn't restore. That
happened to be in one of those rarely-needed checks - it had some data
leftover telling it to scroll just as it started writing new data.
This fragment in charproc.c:
if (!AddToRefresh(screen)) {
/* make sure that the correct GC is current */
currentGC = updatedXtermGC(screen, flags, fg_bg, False);
if (screen->scroll_amt)
FlushScroll(screen);
doesn't account for that one of the functions called by FlushScroll()
could modify the display's colors as is done in updatedXtermGC().
What's odd is that the code is very old - and no one reported it before.
I see the updatedXtermGC() call from 1996. (On the other hand, I've
encountered bugs that old more than once).
Anyway, the fix for that is to move the assignment past the if statement:
if (!AddToRefresh(screen)) {
if (screen->scroll_amt)
FlushScroll(screen);
/* make sure that the correct GC is current */
currentGC = updatedXtermGC(screen, flags, fg_bg, False);
I'll check for other occurrences, of course.
The attached patch fixes the described problem. Please apply and
recompile.
--- xterm-201/charproc.c~redraw
+++ xterm-201/charproc.c
@@ -3435,12 +3435,13 @@
InsertChar(screen, cells);
}
if (!AddToRefresh(screen)) {
- /* make sure that the correct GC is current */
- currentGC = updatedXtermGC(screen, flags, fg_bg, False);
if (screen->scroll_amt)
FlushScroll(screen);
+ /* make sure that the correct GC is current */
+ currentGC = updatedXtermGC(screen, flags, fg_bg, False);
+
if (flags & INVISIBLE) {
if (cells > len) {
str = temp_str = malloc(cells);
-- System Information:
Debian Release: 3.1
APT prefers testing
APT policy: (1050, 'testing'), (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.4.30
Locale: LANG=C, LC_CTYPE=de_DE@euro (charmap=ISO-8859-15)
Versions of packages xterm depends on:
ii libc6 2.3.2.ds1-21 GNU C Library: Shared libraries an
ii libexpat1 1.95.8-1 XML parsing C library - runtime li
ii libfontconfig1 2.3.1-2 generic font configuration library
ii libfreetype6 2.1.7-2.4 FreeType 2 font engine, shared lib
ii libice6 4.3.0.dfsg.1-12.0.1 Inter-Client Exchange library
ii libncurses5 5.4-4 Shared libraries for terminal hand
ii libsm6 4.3.0.dfsg.1-12.0.1 X Window System Session Management
ii libxaw7 4.3.0.dfsg.1-12.0.1 X Athena widget set library
ii libxext6 4.3.0.dfsg.1-12.0.1 X Window System miscellaneous exte
ii libxft2 2.1.7-1 FreeType-based font drawing librar
ii libxmu6 4.3.0.dfsg.1-12.0.1 X Window System miscellaneous util
ii libxpm4 4.3.0.dfsg.1-12.0.1 X pixmap library
ii libxrender1 0.8.3-7 X Rendering Extension client libra
ii libxt6 4.3.0.dfsg.1-12.0.1 X Toolkit Intrinsics
ii xlibs 4.3.0.dfsg.1-12 X Keyboard Extension (XKB) configu
ii xlibs-data 4.3.0.dfsg.1-12 X Window System client data
-- debconf-show failed
---------------------------------------
Received: (at 307216-done) by bugs.debian.org; 2 Aug 2005 23:54:54 +0000
>From ender@debian.org Tue Aug 02 16:54:54 2005
Return-path: <ender@debian.org>
Received: from cerrojo.elmundo.es (mail2.elmundo.es) [193.110.128.12]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1E06b0-0001ms-00; Tue, 02 Aug 2005 16:54:54 -0700
Received: from xanes.el-mundo.int (xanes.elmundo.int [10.5.222.50])
by mail2.elmundo.es (Postfix) with ESMTP
id 0147D4614D; Wed, 3 Aug 2005 01:54:57 +0200 (CEST)
Received: by xanes.el-mundo.int (Postfix, from userid 65500)
id 02FF617316; Wed, 3 Aug 2005 01:54:53 +0200 (CEST)
Received: from localhost (xanes.elmundo.int [10.5.222.50])
by xanes.el-mundo.int (Postfix) with ESMTP
id CBECC17314; Wed, 3 Aug 2005 01:54:52 +0200 (CEST)
From: David =?iso-8859-15?q?Mart=EDnez_Moreno?= <ender@debian.org>
Organization: Debian
To: 307216-done@bugs.debian.org
Subject: Re: Bug#307216: #307216: xterm colorization problems
Date: Wed, 3 Aug 2005 01:54:45 +0200
User-Agent: KMail/1.7.2
References: <[🔎] 20050802231411.GA7497@invisible-island.net>
In-Reply-To: <[🔎] 20050802231411.GA7497@invisible-island.net>
Cc: dickey@his.com
MIME-Version: 1.0
Content-Type: multipart/signed;
boundary="nextPart1457788.0lY4LSUqj0";
protocol="application/pgp-signature";
micalg=pgp-sha1
Content-Transfer-Encoding: 7bit
Message-Id: <200508030154.52151.ender@debian.org>
X-Bogosity: No, tests=bogofilter, spamicity=0.425328, version=0.10.3
Delivered-To: 307216-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
--nextPart1457788.0lY4LSUqj0
Content-Type: text/plain;
charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Version: 6.8.2.dfsg.1-1
El Mi=E9rcoles, 3 de Agosto de 2005 01:14, Thomas Dickey escribi=F3:
> This is fixed in patch #202
Many thanks, Thomas. Closing this bug report, as patchset #202 is included=
in=20
6.8.2.dfsg.1-1 and later.
Regards,
Ender.
=2D-=20
Network engineer
Debian Developer
--nextPart1457788.0lY4LSUqj0
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQBC8AfMWs/EhA1iABsRAhpDAKCs/NHuhX6uwISpOVkodWHUqM1SFACfdVKw
yTg7qcMI9SRoxqAOumjQF9A=
=bVIt
-----END PGP SIGNATURE-----
--nextPart1457788.0lY4LSUqj0--
Reply to: