[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

X Strike Force X.Org X11 SVN commit: r476 - trunk/debian



Author: branden
Date: 2005-08-02 14:35:50 -0500 (Tue, 02 Aug 2005)
New Revision: 476

Modified:
   trunk/debian/libglu1-xorg.postinst.in
Log:
Er, uh, make libglu1-xorg's postinst script actually meaningful, by
actually doing the things that should be done after copying it from a
postrm script(!).  Using a postrm script as a template for a postinst
script is a bad idea; there exist many other postinst scripts in the
package to draw from.
+ Replace the useless body of the script with something actually meaningful
  and useful for a library post-installation script.  (Fortunately, the
  postrm logic was guarded by a test of $1's value, which is never "remove"
  for a postinst script, or this oversight could have had much worse
  consequences.)
+ Fix comments in the file so they accurately describe what the script is.
+ Fix $THIS_SCRIPT variable so that any error messages do not lie to the
  user about which scripts is being run.
+ Set svn:keywords property to "Id" so the copied-over keyword doesn't lie
  about while the file is, either.

This continues the multi-purpose huge commit, r320, and is a good example
of why huge multi-purpose commits should not be done.  :(

To conclude: OW OW OW OW OW OW OW OW OW OW.


Modified: trunk/debian/libglu1-xorg.postinst.in
===================================================================
--- trunk/debian/libglu1-xorg.postinst.in	2005-08-02 19:20:18 UTC (rev 475)
+++ trunk/debian/libglu1-xorg.postinst.in	2005-08-02 19:35:50 UTC (rev 476)
@@ -1,26 +1,24 @@
 #!/bin/sh
-# Debian libglu1-xorg package post-removal script
+# Debian libglu1-xorg package post-installation script
 # Copyright 1998-2001, 2004 Branden Robinson.
 # Licensed under the GNU General Public License, version 2.  See the file
 # /usr/share/common-licenses/GPL or <http://www.gnu.org/copyleft/gpl.txt>.
 # Acknowledgements to Stephen Early, Mark Eichin, and Manoj Srivastava.
 
-# $Id: xlibmesa-glu.postrm.in 189 2005-06-11 00:04:27Z branden $
+# $Id$
 
 set -e
 
 THIS_PACKAGE=libglu1-xorg
-THIS_SCRIPT=postrm
+THIS_SCRIPT=postinst
 
 #INCLUDE_SHELL_LIB#
 
-if [ "$1" = "remove" ]; then
-  deregister_x_lib_dir_with_ld_so
-  ldconfig
-fi
+register_x_lib_dir_with_ld_so
+ldconfig
 
 #DEBHELPER#
 
 exit 0
 
-# vim:set ai et sts=2 sw=2 tw=0:
+# vim:set ai et sts=2 sw=2 tw=80:


Property changes on: trunk/debian/libglu1-xorg.postinst.in
___________________________________________________________________
Name: svn:keywords
   + Id



Reply to: