Hi,
here are my comments on most of the 099* patches.
099a_improve_search_for_libXcursor.diff -- present under same name
099b_Xft_FreeType_2.1.7_build_fix.diff -- upstream
099c_support_loadable_external_Xcursor_lib.diff -- present under same name
099d_Imake.rules_fix_RawCppFileTarget.diff -- lost
099e_XF86Config_manpage_overhaul.diff -- modified and attached to this mail
(099e_xorgconf_manpage_overhaul.diff)
099f_savage_driver_disable_randr_on_rotation.diff -- present under same name
099g_xkb_symbols_polish_fix_keypad_separator.diff -- present under same name
099h_mesa_tdfx_load_right_glide_library.diff -- second hunk changed. I don't
know which one is right.
099i_pro_savage_ddr_set_use_bios_to_false.diff -- lost
099j_xkb_new_layouts.diff -- present under same name, except for
rules/xfree86:
+ Remove special case that causes PC keyboard models with the us_intl
layout to load the us layout and add the us_intl layout to it.
which is upstream in rules/xorg.
099k_Compose_fix_latin1_UTF8.diff -- present under same name
099l_neomagic_magic_poke_for_video_performance.diff -- upstream
099m_mga_increase_minimum_pixel_clock.diff -- modified patch present under
same name
099n_fbdev_driver_message_improvements.diff -- present under same name
099o_ati_radeon_fix_SEGV_in_display_query.diff -- probably unneeded with
new version of the driver
099p_xkb_brazilian_fix_keypad_separator.diff -- present under same name
099q_tdfx_improve_mode_rejection_diagnostics.diff -- ported patch attached
099r_xlsfonts_do_not_spew_usage_on_connection_error.diff -- lost, rediffed
patch attached
099s_selinux_support.diff -- lost
099t_xkb_remove_hidden_attributes.diff -- lost
099u_mkdirhier_rewrite.diff -- lost
099v_fontserver_fix_SEGV.diff -- lost
099w_fix_XGetWProp_manpage.diff -- upstream
099x_xdm_support_logfile_rotation.diff -- lost
099z_xkb_fix_rules_xfree86.diff -- don't know yet, someone needs to check
against new patch 099y.
099z_xkb_level3_ralt_switch.diff -- present under same name, but without
changes to:
xc/programs/xkbcomp/symbols/pc/dvorak
xc/programs/xkbcomp/symbols/pc/pl
xc/programs/xkbcomp/symbols/pc/pl2
Cheers,
Julien Cristau
Attachment:
099e_xorgconf_manpage_overhaul.diff.gz
Description: Binary data
$Id: 099q_tdfx_improve_mode_rejection_diagnostics.diff 2132 2005-01-12 07:11:51Z branden $
The tdfx driver rejects modes without explaining why to the user. Fix this
by logging the reason.
This patch by Branden Robinson.
Not submitted upstream to XFree86 or X.Org.
Index: xc/programs/Xserver/hw/xfree86/drivers/tdfx/tdfx_driver.c
===================================================================
--- xc/programs/Xserver/hw/xfree86/drivers/tdfx/tdfx_driver.c (revision 285)
+++ xc/programs/Xserver/hw/xfree86/drivers/tdfx/tdfx_driver.c (working copy)
@@ -2406,8 +2406,16 @@
TDFXPtr pTDFX;
TDFXTRACE("TDFXValidMode start\n");
- if ((mode->HDisplay>2048) || (mode->VDisplay>1536))
+ if (mode->HDisplay>2048) {
+ xf86DrvMsg(scrnIndex, X_INFO, "rejecting mode with horizontal resolution %d"
+ " exceeding maximum of 2048\n", mode->HDisplay);
return MODE_BAD;
+ }
+ if (mode->VDisplay>1536) {
+ xf86DrvMsg(scrnIndex, X_INFO, "rejecting mode with vertical resolution %d"
+ " exceeding maximum of 1536\n", mode->VDisplay);
+ return MODE_BAD;
+ }
/* Banshee doesn't support interlace, but Voodoo 3 and higher do. */
pScrn = xf86Screens[scrnIndex];
pTDFX = TDFXPTR(pScrn);
@@ -2421,13 +2429,19 @@
return MODE_OK;
break;
default:
+ xf86DrvMsg(scrnIndex, X_INFO, "rejecting mode with unsupported"
+ " interlace flag\n");
return MODE_BAD;
break;
}
}
/* In clock doubled mode widths must be divisible by 16 instead of 8 */
- if ((mode->Clock>TDFX2XCUTOFF) && (mode->HDisplay%16))
+ if ((mode->Clock>TDFX2XCUTOFF) && (mode->HDisplay%16)) {
+ xf86DrvMsg(scrnIndex, X_INFO, "rejecting mode with horizontal resolution %d"
+ " not divisibile by 16 and clock %d greater than %d\n",
+ mode->HDisplay, mode->Clock, TDFX2XCUTOFF);
return MODE_BAD;
+ }
return MODE_OK;
}
$Id: 099r_xlsfonts_do_not_spew_usage_on_connection_error.diff 2130 2005-01-11 07:26:36Z branden $
This patch by Branden Robinson.
General philosophy:
The user should only be shown a usage messages when:
* it is asked for with a --help option or the like.
* the command line is syntactically invalid.
Because xlsfonts's dsimple.c source file is also used in xprop, xwd, and
xwininfo, this patch also corrects this behavior for those programs.
Not submitted upstream to XFree86 or X.Org.
Index: xc/programs/xlsfonts/dsimple.c
===================================================================
--- xc/programs/xlsfonts/dsimple.c (revision 285)
+++ xc/programs/xlsfonts/dsimple.c (working copy)
@@ -188,8 +188,7 @@
if (d == NULL) {
fprintf (stderr, "%s: unable to open display '%s'\n",
program_name, XDisplayName (display_name));
- usage ();
- /* doesn't return */
+ exit (1);
}
return(d);
Attachment:
signature.asc
Description: Digital signature