retitle 285807 xserver-xfree86: [core server] MiscPassMessage() implementation broken and leaks memory tag 285807 + upstream patch moreinfo thanks On Wed, Dec 15, 2004 at 07:25:50PM +0100, Thomas Winischhofer wrote: > Package: xserver-xfree86 > Version: 4.3.0.dfsg.1-9 > > Branden, > Fabio, > > In June 2004, you added a patch to the Debian SVN that added the > MiscPassMessage() mechanism for the misc extension[0]. > > As it turned out yesterday during my attempts of actually using this > mechanism, it is entirely broken due to > > 1) a severe bug in the handling of the message value string (the message > value was copied from an invalid memory location), and > > 2) two severe memory leaks. > > I have committed patches to fix this to the XFree86 CVS today (Dec 15), > changing two files: > > - xc/programs/Xserver/Xext/xf86misc.c > - xc/include/extensions/xf86mscstr.h > > The first file was subject to three commits on Dec 15 [1] (2 by me, one > by Marc Aurele De France fixing a small bug in my first patch) > > I am sorry for not being able to provide you with patches relative to > Debian's current versions of these files (my HD already carries 8 > complete source trees of XFree86 and X.org). > > Anyhow, I encourage you to grab these patches from XFree86 CVS in order > to complete the mission originally intended. > > My changes are NOT covered by the XFree86 license 1.1 but the old > license, which is GPL compatible as we all know. The very same patches > went into X.org CVS as of today as well. Hi Thomas, I'm sorry it's taken a long time to get back to you. I'm attaching a patch, based on freedesktop.org CVS (xorg module). I note that your latest fixes to the MiscPassMessage() implementation are only on xorg HEAD, and not in the X.Org X11 6.8.2 release. I would therefore need to backport these fixes into the new xorg-x11 SVN repository as well so that this fix doesn't regress. Do my observations and patch look sane to you? -- G. Branden Robinson | Organized religion is a sham and a Debian GNU/Linux | crutch for weak-minded people who branden@debian.org | need strength in numbers. http://people.debian.org/~branden/ | -- Jesse Ventura
Attachment:
signature.asc
Description: Digital signature