Bug#290238: Overquoting in xvfb-run
Package: xvfb
Version: 4.3.0.dfsg.1-10
xvfb-run no longer works correctly. Looking at the code and the
changelog, it appears it's been pretty much unusable since
4.3.0.dfsg.1-9 was uploaded on 9th December 2004, so I guess it's not a
particular popular utility. But I find it very useful, so I tracked
down what's going wrong.
The problem is quoting of the arguments passed to Xvfb - both $XVFBARGS
and $LISTENTCP are quoted, so each is passed as a single argument and
Xvfb fails to understand them. Removing the double quotes allows the
shell to split them into several arguments to Xvfb, and xvfb-run works
once again. Here's a patch:
--- /usr/bin/xvfb-run 2004-12-15 19:15:49.000000000 +0000
+++ xvfb-run 2005-01-13 03:48:02.000000000 +0000
@@ -140,7 +140,7 @@
MCOOKIE=$(mcookie)
XAUTHORITY=$AUTHFILE xauth add ":$SERVERNUM" "$XAUTHPROTO" "$MCOOKIE" \
>"$ERRORFILE" 2>&1
-XAUTHORITY=$AUTHFILE Xvfb ":$SERVERNUM" "$XVFBARGS" "$LISTENTCP" >"$ERRORFILE" \
+XAUTHORITY=$AUTHFILE Xvfb ":$SERVERNUM" $XVFBARGS $LISTENTCP >"$ERRORFILE" \
2>&1 &
XVFBPID=$!
sleep "$STARTWAIT"
Incidentally, I noticed that the changelog.Debian currently contains
what appears to be some leftovers from a CVS conflict:
<<<<<<< .working
-- Fabio M. Di Nitto <fabbione@fabbione.net> Thu, 09 Dec 2004 17:14:45 +0100
=======
-- Fabio M. Di Nitto <fabbione@fabbione.net> Thu, 9 Dec 2004 17:14:45 +0100
>>>>>>> .merge-right.r2073
Cheers,
Olly
Reply to: