[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Support for VIA driver, patch against SVN HEAD



Using my "sanitized XFree86 CVS" tree, I have prepared my own
000_stolen_from_HEAD_via_driver.diff, which stops at 2003-02-12, the day
before the application of the XFree86 1.1 to the tree.

This lost 3 small commits:

1)  CVSROOT:        /home/x-cvs
    Module name:    xc
    Changes by:     dawes@public.xfree86.org.       04/02/20 13:46:36

    Log message:
       814. Fix missing ';' in via_driver.c hidden by an empty macro (Bugzilla #813,
            Luc Verhaegen).

    Modified files:
          xc/programs/Xserver/hw/xfree86/:
            CHANGELOG
          xc/programs/Xserver/hw/xfree86/doc/sgml/:
            RELNOTES.sgml
          xc/programs/Xserver/hw/xfree86/drivers/via/:
            via_driver.c

      Revision      Changes    Path
      3.3152        +3 -1      xc/programs/Xserver/hw/xfree86/CHANGELOG
      1.114         +2 -1      xc/programs/Xserver/hw/xfree86/doc/sgml/RELNOTES.sgml
      1.29          +2 -2      xc/programs/Xserver/hw/xfree86/drivers/via/via_driver.c

2)  CVSROOT:        /home/x-cvs
    Module name:    xc
    Changes by:     dawes@public.xfree86.org.       04/02/20 13:50:07

    Log message:
       815. Fix for detection of hardwired panel for the via driver (Bugzilla #813,
            Luc Verhaegen, reported by Johannes Specht).

    Modified files:
          xc/programs/Xserver/hw/xfree86/:
            CHANGELOG
          xc/programs/Xserver/hw/xfree86/drivers/via/:
            via_bios.c

      Revision      Changes    Path
      3.3153        +3 -1      xc/programs/Xserver/hw/xfree86/CHANGELOG
      1.11          +19 -1     xc/programs/Xserver/hw/xfree86/drivers/via/via_bios.c

3)  CVSROOT:        /home/x-cvs
    Module name:    xc
    Changes by:     tsi@public.xfree86.org. 04/03/15 07:04:22

    Log message:
      Fix driver name

    Modified files:
          xc/programs/Xserver/hw/xfree86/drivers/via/:
            via_driver.c

      Revision      Changes    Path
      1.30          +2 -4      xc/programs/Xserver/hw/xfree86/drivers/via/via_driver.c

There have been four commits since then:

4)  CVSROOT:        /home/x-cvs
    Module name:    xc
    Changes by:     dawes@public.xfree86.org.       04/03/17 23:07:14

    Log message:
      A second invocation of 'make' shouldn't change anything.

      --
      These changes are Copyright (c) 2004 The XFree86 Project, Inc
      Rights as per version 1.1 of the XFree86 License
      (http://www.xfree86.org/legal/licenses.html).

    Modified files:
    [SNIP a whole bunch of files]
      1.9           +2 -2      xc/programs/Xserver/hw/xfree86/drivers/via/Imakefile
    [SNIP more]

That is the commit you said broke the build, right?

5)  CVSROOT:        /home/x-cvs
    Module name:    xc
    Changes by:     tsi@public.xfree86.org. 04/03/29 08:25:22

    Log message:
        40. Address Xv segfaults with Option "XaaNoSolidFillRect" by reducing output
            driver dependence on xaalocal.h (Marc La France).

    Modified files:
    [SNIP another gigantic commit]
      1.12          +1 -2      xc/programs/Xserver/hw/xfree86/drivers/via/via_accel.c
      1.5           +1 -2      xc/programs/Xserver/hw/xfree86/drivers/via/via_dga.c
      1.31          +1 -2      xc/programs/Xserver/hw/xfree86/drivers/via/via_driver.c
      1.18          +5 -38     xc/programs/Xserver/hw/xfree86/drivers/via/via_video.c

6)  CVSROOT:        /home/x-cvs
    Module name:    xc
    Changes by:     dawes@public.xfree86.org.       04/04/03 13:39:55

    Log message:
        56. Via driver updates:
            - Workaround for not properly detected memory allocation failure
              of the drm module.
            - In case of drm memory allocation failure, added a fallback to
              linear allocation in the pixmap cache when XFREE86_44 is set.
            - Increased the pixmap cache size to the hardware blitting limit
              if XFREE86_44 is set.
            - Restructuring and cleanups in via_accel.c (Removed unecessary
              comments and moved ViaInitLinear to via_memory.c)
            - Fixed some warnings about unresolved drm symbols.
            (Bugzilla #1320, Thomas Hellstr?m).

    Modified files:
          xc/programs/Xserver/hw/xfree86/:
            CHANGELOG
          xc/programs/Xserver/hw/xfree86/drivers/via/:
            via_accel.c via_driver.c via_driver.h via_memory.c

      Revision      Changes    Path
      3.3206        +12 -1     xc/programs/Xserver/hw/xfree86/CHANGELOG
      1.13          +12 -54    xc/programs/Xserver/hw/xfree86/drivers/via/via_accel.c
      1.32          +3 -1      xc/programs/Xserver/hw/xfree86/drivers/via/via_driver.c
      1.14          +10 -4     xc/programs/Xserver/hw/xfree86/drivers/via/via_driver.h
      1.6           +72 -28    xc/programs/Xserver/hw/xfree86/drivers/via/via_memory.c

7)  CVSROOT:        /home/x-cvs
    Module name:    xc
    Changes by:     dawes@public.xfree86.org.       04/04/03 14:05:02

    Log message:
        59. Cleanup the via driver's primary DDC/EDID retrieval:
            - Remove NoDDCValue entirely (also adapts the manpage now).
            - Comment out ddc1 and ddc1Read, as this is broken.
            - Replace ddc2Read with xf86DoEDID_DDC2.
            - Replace manually setting ranges for xf86SetDDCproperties.
            (Bugzilla #812, Luc Verhaegen).

    Modified files:
          xc/programs/Xserver/hw/xfree86/:
            CHANGELOG
          xc/programs/Xserver/hw/xfree86/drivers/via/:
            via.man via_driver.c via_driver.h

      Revision      Changes    Path
      3.3209        +7 -1      xc/programs/Xserver/hw/xfree86/CHANGELOG
      1.5           +1 -4      xc/programs/Xserver/hw/xfree86/drivers/via/via.man
      1.33          +31 -85    xc/programs/Xserver/hw/xfree86/drivers/via/via_driver.c
      1.15          +1 -2      xc/programs/Xserver/hw/xfree86/drivers/via/via_driver.h

This leaves a few questions open:

A) What does David Dawes regard as "attribution to [him]"?[1]  If the
   responsibility for the CVS commit is attributed to him, as it appears
   to be in several of the above, does he consider the XFree86 1.1
   license to attach to those changes?

B) What is Marc La France's policy regarding the application of the
   XFree86 1.1 license to modifications he makes to files that bear no
   copyright notice by him or by the XFree86 Project, Inc.?

C) Does the XFree86 Project, Inc., consider patches submitted to their
   Bugzilla system to have any applicable copyrights therein assigned to
   them?

Is there someone who'd like to broach these questions with the XFree86
Project?  My mails seem to go unanswered.

At any rate, for any of the above where we can get the licensing
straightened out, I'd be happly to apply the relevant patches.  It may
be worth contacting Thomas Hellström and Luc Verhaegen to inquire as to
the provenance of their patches.

For the others, I am willing to write up a plain-English description as
I did for the AT ioctl() issue.

[1] http://www.mail-archive.com/devel%40xfree86.org/msg05906.html

-- 
G. Branden Robinson                |        People with power understand
Debian GNU/Linux                   |        exactly one thing: violence.
branden@debian.org                 |        -- Noam Chomsky
http://people.debian.org/~branden/ |

Attachment: signature.asc
Description: Digital signature


Reply to: