[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: debian/patches status: linux.cf and xfree86.cf patches



On Fri, Jan 02, 2004 at 03:47:54PM -0500, Nathanael Nerode wrote:
> * linux.cf: GccAliasingArgs is in OptimizedCDebugFlags upstream, but dropped 
> in the Debian patch, for HPArchitecture, ia64Architecture, 
> Mc68020Architecture, MipsArchitecture, s390Architecture, SparcArchitecture, 
> and SuperHArchitecture.

I've added it back.

> * linux.cf: -fomit-frame-pointer is in OptimizedCDebugFlags upstream, but 
> dropped in the Debian patch, for s390Architecture, s390xArchitecture.

I don't think this should be set for any architecture (as I understand
it, it can make stack traces useless), so this is deliberate.

> * In xfree86.cf, DefaultGcc2i386Opt, DefaultGcc2AxpOpt, and DefaultGcc2PpcOpt 
> are defined to contain GccAliasingArgs.  But in linux.cf, they're defined to 
> *not* contain it.

I've fixed this.

> Note that GccAliasingArgs was introduced upstream sometime after 4.2.  How 
> precisely should it be handled for Debian?

Per Michel's suggestion, we're using it for every architecture now.

> * The following silly little fix for unspecified architectures was in 
> 001_linux_cf.diff, but isn't in the new patch:
> @@ -686,6 +693,7 @@
>  #  endif /* x86_64Architecture */
>  # else
>  #  define CcCmd                        gcc
> +#  define CplusplusCmd         g++
>  #  define AsCmd                        CcCmd -c -x assembler
>  #  define LdCmd                        CcCmd -nostdlib
>  #  define AsmDefines           -DUSE_GAS

Added back.

> * linux.cf: HPArchitecture doesn't wrap its definition of OptimizedCDebugFlags 
> in the usual #ifndef upstream, and the new patch doesn't either.  But the old 
> patch did.

I've fixed this.

I'll be committing these changes once I've written up the changeset
appropriately.  There were other bits of sloppiness I wanted to fix.

Thank you very much yet again for your work on the patch migration
front.

-- 
G. Branden Robinson                |    Religion consists in a set of
Debian GNU/Linux                   |    things which the average man thinks
branden@debian.org                 |    he believes and wishes he was
http://people.debian.org/~branden/ |    certain of.           -- Mark Twain

Attachment: signature.asc
Description: Digital signature


Reply to: