On Wed, Jan 14, 2004 at 08:21:32PM -0500, Nathanael Nerode wrote: > Submitted for your consideration (and it should go upstream, too). > This is deeply obvious, but I added comments to explain what's being done > here. > > (So just in case copyright issues apply to the comments or something: > > Permission to use, copy, modify, distribute, and sell this patch for > any purpose is hereby granted without fee. I make no representation > about the suitability of it for any purpose. It is provided "as is" without > express or implied warranties.) > > This is untested, but it ought to work. Nope, still busted: gcc -c -g -O2 -ansi -pedantic -Wall -Wpointer-arith -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wredundant-decls -Wnested-externs -Wundef -fno-merge-constants -I../../../../../../programs/Xserver/hw/xfree86/common -I../../../../../../programs/Xserver/hw/xfree86/os-support -I. -I../../../../../../programs/Xserver/include -I../../../../../../exports/include/X11 -I../../../../../../include/extensions -I../../../../../../programs/Xserver/hw/xfree86/os-support/shared -I../../../../../../programs/Xserver/mi -I../../../../../.. -I../../../../../../exports/include -Dlinux -D__sparc__ -D_POSIX_C_SOURCE=199309L -D_POSIX_SOURCE -D_XOPEN_SOURCE -D_BSD_SOURCE -D_SVID_SOURCE -D_GNU_SOURCE -DSHAPE -DXINPUT -DXKB -DLBX -DXAPPGROUP -DXCSECURITY -DTOGCUP -DXF86BIGFONT -DDPMSExtension -DPIXPRIV -DPANORAMIX -DRENDER -DRANDR -DGCCUSESGAS -DAVOID_GLYPHBLT -DPIXPRIV -DSINGLEDEPTH -DXFreeXDGA -DXvExtension -DXFree86LOADER -DXFree86Server -DXF86VIDMODE -DXvMCExtension -DSMART_SCHEDULE -DBUILDDEBUG -DXResExtension -DX_BYTE_ORDER=X_BIG_ENDIAN -DNDEBUG -DFUNCPROTO=15 -DNARROWPROTO -DUSESTDRES -DHAVE_SYSV_IPC lnx_kbd.c lnx_kbd.c: In function `KIOCSRATE_ioctl_ok': lnx_kbd.c:156: error: structure has no member named `period' lnx_kbd.c:158: error: structure has no member named `period' lnx_kbd.c:159: error: structure has no member named `period' lnx_kbd.c: In function `SetKbdRepeat': lnx_kbd.c:178: warning: unused variable `i' lnx_kbd.c:179: warning: unused variable `timeout' lnx_kbd.c:180: warning: unused variable `value' lnx_kbd.c:190: warning: unused variable `valid_rates' lnx_kbd.c:196: warning: unused variable `valid_delays' lnx_kbd.c: In function `evdevKbdInit': lnx_kbd.c:698: warning: assignment from incompatible pointer type make[8]: *** [lnx_kbd.o] Error 1 Hmm, looks like the same change needs to be made two places. Bother. -- G. Branden Robinson | It's like I have a shotgun in my Debian GNU/Linux | mouth, I've got my finger on the branden@debian.org | trigger, and I like the taste of http://people.debian.org/~branden/ | the gunmetal. -- Robert Downey, Jr.
Attachment:
signature.asc
Description: Digital signature