Bug#285807: MiscPassMessage() broken
Package: xserver-xfree86
Version: 4.3.0.dfsg.1-9
Branden,
Fabio,
In June 2004, you added a patch to the Debian SVN that added the
MiscPassMessage() mechanism for the misc extension[0].
As it turned out yesterday during my attempts of actually using this
mechanism, it is entirely broken due to
1) a severe bug in the handling of the message value string (the message
value was copied from an invalid memory location), and
2) two severe memory leaks.
I have committed patches to fix this to the XFree86 CVS today (Dec 15),
changing two files:
- xc/programs/Xserver/Xext/xf86misc.c
- xc/include/extensions/xf86mscstr.h
The first file was subject to three commits on Dec 15 [1] (2 by me, one
by Marc Aurele De France fixing a small bug in my first patch)
I am sorry for not being able to provide you with patches relative to
Debian's current versions of these files (my HD already carries 8
complete source trees of XFree86 and X.org).
Anyhow, I encourage you to grab these patches from XFree86 CVS in order
to complete the mission originally intended.
My changes are NOT covered by the XFree86 license 1.1 but the old
license, which is GPL compatible as we all know. The very same patches
went into X.org CVS as of today as well.
Thomas
[0] : http://lists.debian.org/debian-x/2004/06/msg00629.html
[1] : http://www.mail-archive.com/cvs-commit@xfree86.org/msg04005.html
http://www.mail-archive.com/cvs-commit@xfree86.org/msg04006.html
and two following (not yet in mail archive as of this writing)
--
Thomas Winischhofer
Vienna/Austria
thomas AT winischhofer DOT net *** http://www.winischhofer.net
twini AT xfree86 DOT org
Reply to: