[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#271525: xserver-xfree86: Modes should have default depending upon mode-list



retitle 271525 xserver-xfree86: [debconf] set default mode based on answer to mode-list selection
thanks

On Mon, Sep 13, 2004 at 06:49:01PM +0200, Laurent Martelli wrote:
> Package: xserver-xfree86
> Version: 4.3.0.dfsg.1-7
> Severity: normal
> 
> I selected "1024 x 768 @ 75hz" from the mode list, but in the next
> question (xserver-xfree86/config/display/modes), only 800x600 and
> 640x480 were checked. I think it would be nice if the highest resolution
> were checked automatically depending on our choice to the monitor
> question. 

Way ahead of ya.  :)

In fact, I committed a fix to do exactly this -- along with a whole bunch
of other changes -- on 31 August to the "debconf-overhaul" branch in
Debian's XFree86 Subversion repository.

We're hoping to have the debconf-overhaul work completed and merged onto
the trunk for 4.3.0.dfsg.1-9.  Some more testers would be appreciated,
though -- let us know if you're interested.

The commit message follows, with the part of interest to you highlighted
with asterisks (*).

------------------------------------------------------------------------
r1777 | branden | 2004-08-31 02:00:06 -0500 (Tue, 31 Aug 2004) | 67 lines
Changed paths:
   M /branches/debconf-overhaul/debian/CHANGESETS
   M /branches/debconf-overhaul/debian/TODO
   M /branches/debconf-overhaul/debian/changelog
   M /branches/debconf-overhaul/debian/xserver-xfree86.config.in
   M /branches/debconf-overhaul/debian/xserver-xfree86.templates

Almost-but-not-quite overhaul the xserver-xfree86 packages .config script
(with some adjunct changes to its debconf templates).
+ Become aware of the X server symlink and XFree86 X server configuration
  file checksums, so if the files have been locally modified, we don't
  uselessly ask debconf questions that will have no effect.  (Ideally,
  we'd update the debconf database with what we see in those file instead
  of just bailing, but this is still an improvement over the status quo.)
  (Closes: #229097)
+ Implement new trace() function which wraps observe() but also logs the
  logical flow of the config script to
  /var/log/xserver-xfree86{,-dbg}.config.log.  Eliminate debug_echo()
  function in favor of trace(), and update all calls to the former to use
  the latter instead.
+ Rename priority_ceil() to set_db_priority() make it actually change the
  $PRIORITY global variable instead of just returning a value.  Upgrade a
  couple of debugging statements in this function which are issued under
  very strange circumstances to warn()ings.  (We want to receive bug
  reports about these, if they happen.)  Call set_db_priority() instead of
  setting $PRIORITY "manually".
+ Refactor the gigantic "main loop" of the script into a set of functions
  with discrete purposes: select_default_x_server(),
  configure_xfree86_x_server(), configure_video_device(),
  configure_keyboard(), configure_mouse(), configure_monitor(),
  configure_display_modes_and_depth(), configure_server_modules(),
  configure_files(), and configure_dri().  The main loop now handles only
  argument analysis, various debconf data migration issues, and dealing
  with local modification of the configuration files (see above).
  Hopefully this change makes the code a little easier to follow and
  update.
+ Calculate the default value of the
  xserver-xfree86/config/device/use_fbdev question with a little more
  intelligence.  Before doing the existing check of /proc/fb's existence
  and its contents, set the default to false if our architecture is alpha,
  hurd-i386, or i386, and true otherwise.
********************************************
+ When using the "medium" monitor configuration interface, set the default
  display video mode based on the resolution selected.  Document this
  behavior in the xserver-xfree86/config/monitor/mode-list template
  description.  (This default is later overridden if and only if the
  selected display driver doesn't support that resolution.)
********************************************
+ Make the "medium" monitor configuration interface the default, since LCD
  flat panel displays are so much more common relative to four years ago.
  Also ask this question at medium debconf priority.  Thanks to Joey Hess
  for the suggestions.  (Closes: #226365, #242216)
+ Add "1152x864" and "1024x768" to the final fallback list of default
  modes, if we don't already know what the user wants.
+ Remove kludge that omitted the "dri" XFree86 server module from the
  default list of modules to load on SPARC; this was a workaround for a
  bug that has since been fixed, per Steve King and Christian
  Guggenberger.
+ Offer advice to users in the U.S., U.K., Canada, Australia, and New
  Zealand regarding the default XKB layout in the English version of the
  template.  (Several translators have already picked up on this, but the
  translations of the xserver-xfree86/config/inputdevice/keyboard/layout
  template should be localized beyond just a translation -- a literal
  translation of the final part of the template's text is not the best way
  to serve our users.  Instead, each language should advise the user about
  the keyboard layouts most used by speakers of that language.)
  (Closes: #133344)
+ Include the v4l server module in the list of available (and default)
  modules to load.  Add description of this module to
  xserver-xfree86/config/modules template description.  Refer to XVideo
  extension as such instead of "Xv".  (Closes: #135768)

Add more comments to xserver-xfree86 config script.

Update shell style in xserver-xfree86 config script.

------------------------------------------------------------------------
-- 
G. Branden Robinson                |      A fundamentalist is someone who
Debian GNU/Linux                   |      hates sin more than he loves
branden@debian.org                 |      virtue.
http://people.debian.org/~branden/ |      -- John H. Schaar

Attachment: signature.asc
Description: Digital signature


Reply to: